Daemon threads for auto-reload?

33 views
Skip to first unread message

Mark Feeney

unread,
Jan 22, 2014, 10:14:31 AM1/22/14
to enliv...@googlegroups.com
Hi.

I've been using auto-reload and it generally works for me.  One catch is that the reload threads are non-daemon (running, via `future`, in the agent-send-off thread pool) and will block orderly JVM shutdown.  This manifests with `lein run` and `mvn test` if you're unlucky enough to have to use Maven (via clojure-maven-plugin).

I have a small patch https://github.com/overthink/enlive/commit/714867c8712366ae7d6210262eeac018975403c1 that "fixes" it by making the threads daemon=true.

Any interest in this patch?  If yes, what's the contribution procedure?  Should I just send a PR?

Thanks,


Mark.

Reply all
Reply to author
Forward
0 new messages