Anthology of Interest
Steven Rogers
- Dojo is still in public/javascripts - weren't we going to jettison that? The project is kind of big.
- The templates in nav_menu.html.erb defines nav_menu_items which duplicates a lot of info in the DB and seems to limit what's shown in the display regardless of the settings in the Admin screen/DB. That seems a bit funny.
- in facebook_clone.css line 41 #navigation is broken by setting width: 300px; which makes any additional items (like manage) wrap. 600px seems about right
- home_controller.rb line 94 says HtmlContent.find_by_content_id('privacy') when probably means to say: HtmlContent.find_by_title('privacy')
- It would be cool to have a "terms of service" link in the footer next to privacy, since Facebook requires a Terms of Service link. I cloned one for myself out of the code for privacy.
- for the configuration.rb model - it would be handy if this were just read from a config/something.yml file or defined in an initializer
- it looks like the basic home/index action for "/" bounces through quite a few things and gets errors before checking to see that there's no user and going to the login page.
- The links for friend operations only appear in the column-based widget and not in /users/1/friends where they're display on the full page - not really a bug, but kind of counter-intuitive that you're on a page that says "Pending Friends" but you can't do anything with them.
- the plugin gmail_smtp breaks SendGrid on Heroku - just a note as that wouldn't apply to everyone, but handy to know.
- the way the divs are set up in the FB clone header, shrinking the window causes the tabs to wrap down into the body.
- if you do HTML Content delete function in admin pages, you get a Template is Missing error. It needs on line 286:
def content_delete
@html_content = HtmlContent.find(params[:id])
@html_content.destroy
redirect_to :action => 'contents'
end
- if you click on "privacy policy" when not logged in (with FB template) then you're stuck. Maybe link the Logo Text at the top to the root path?
That's all I've found so far. In general, this seems like a big step up. Just keeps getting better and better . . .
SR
Timothy Fisher
First let me say thank you very much for the detailed feedback. It is feedback like yours that helps keep me on track and assured that what I am doing is meeting the needs of users. I will be going through your items one-by-one and responding to them in a follow-up email. Having glanced through them, in general I think it's mainly things that I agree with your assessment of and that I need to get cleaned up.
Please keep up the feedback!
Tim
--
You received this message because you are subscribed to the Google Groups "EngineY" group.
To post to this group, send email to eng...@googlegroups.com.
To unsubscribe from this group, send email to enginey+u...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/enginey?hl=en.
Timothy Fisher
I had a chance to play around with the latest version of EngineY - here's a few items. First, wow, what a lot of changes! The Facebook Clone template is nice. I picked that particular one to play around with for the notes below:
- Dojo is still in public/javascripts - weren't we going to jettison that? The project is kind of big.
- The templates in nav_menu.html.erb defines nav_menu_items which duplicates a lot of info in the DB and seems to limit what's shown in the display regardless of the settings in the Admin screen/DB. That seems a bit funny.
- in facebook_clone.css line 41 #navigation is broken by setting width: 300px; which makes any additional items (like manage) wrap. 600px seems about right
- home_controller.rb line 94 says HtmlContent.find_by_content_id('privacy') when probably means to say: HtmlContent.find_by_title('privacy')
- It would be cool to have a "terms of service" link in the footer next to privacy, since Facebook requires a Terms of Service link. I cloned one for myself out of the code for privacy.
- for the configuration.rb model - it would be handy if this were just read from a config/something.yml file or defined in an initializer
- it looks like the basic home/index action for "/" bounces through quite a few things and gets errors before checking to see that there's no user and going to the login page.
- The links for friend operations only appear in the column-based widget and not in /users/1/friends where they're display on the full page - not really a bug, but kind of counter-intuitive that you're on a page that says "Pending Friends" but you can't do anything with them.
- the plugin gmail_smtp breaks SendGrid on Heroku - just a note as that wouldn't apply to everyone, but handy to know.
- the way the divs are set up in the FB clone header, shrinking the window causes the tabs to wrap down into the body.
- if you do HTML Content delete function in admin pages, you get a Template is Missing error. It needs on line 286:
def content_delete
@html_content = HtmlContent.find(params[:id])
@html_content.destroy
redirect_to :action => 'contents'
end
- if you click on "privacy policy" when not logged in (with FB template) then you're stuck. Maybe link the Logo Text at the top to the root path?
That's all I've found so far. In general, this seems like a big step up. Just keeps getting better and better . . .
Steven Rogers
On Aug 2, 2010, at 7:55 AM, Timothy Fisher wrote:
>> - the plugin gmail_smtp breaks SendGrid on Heroku - just a note as that wouldn't apply to everyone, but handy to know.
>
> Hmm, not sure what do do about this at the moment since I am relying on that plugin.
Yeah - I don't think you can do anything about that except perhaps mention it in the documentation.
Another thing I noticed: for the analytics code, you could have
render '/layouts/analytics' if Rails.env == 'production'
so that local development would automatically be omitted regardless
SR
Timothy Fisher
Tim
SR
Steven Rogers
I didn't notice that the FB skin doesn't have a regular user signup link, so I added that in.
But apparently there's some issues in UserMailer with the @url variable and body[:url] (might be because I'm using Rails 2.3.8 and the default was 2.3.5) - anyway - the @url defined in UserMailer.init (i.e. the network name) is what comes out in the body - e.g. the activation email only contains the root URL, not the activation code. I changed @url to @root_url throughout and then everything works as expected. It seems like there's some conflict between @url and body[:url]
Also, it would be cool if RubyMI didn't appear as literal text everywhere in the mail. In lots of places, it could just be omitted without even making it a user-defined symbol - like "you can now participate fully in the RubyMI community" could just be "you can now participate fully in the community".
Regards,
SR
Timothy Fisher
Tim
SR
Timothy Fisher
Tim