code/clock.py

10 views
Skip to first unread message

MestreLion

unread,
Mar 30, 2012, 8:25:01 AM3/30/12
to endgame-sin...@googlegroups.com
I was adjusting README.txt, to update some of the outdated info there, when I read this:

164: Portions Copyright (C) 2005 Adam Bark.  See code/clock.py for details.

But... there is no code/clock.py file. It was deleted in Sat Aug 2 22:32:34 2008 +0000, commit f8d94f427982786ebfa99852f3f214dee0f475b4, and all references to it were removed in the next 2 commits made the same day.

Should we remove the "See code/clock.py for details." part? Are his contributions still used anywhere in current code? What about line 125?

Side-note: from now on, I'll also publish some of my "testing/*" branches, so you can see what I am currently working on, and correct me if I deviate to a wrong path. But /please/ do not work on top of them, because I constantly rebase/amend such commits.

ML

Phil Bordelon

unread,
Mar 30, 2012, 9:13:29 AM3/30/12
to endgame-sin...@googlegroups.com
On 03/30/2012 07:25 AM, MestreLion wrote:
> I was adjusting README.txt, to update some of the outdated info there,
> when I read this:
>
> 164: Portions Copyright (C) 2005 Adam Bark. See code/clock.py for details.
>
> But... there is no code/clock.py file. It was deleted in Sat Aug 2
> 22:32:34 2008 +0000, commit f8d94f427982786ebfa99852f3f214dee0f475b4,
> and all references to it were removed in the next 2 commits made the
> same day.
>
> Should we remove the "See code/clock.py for details." part? Are his
> contributions still used anywhere in current code? What about line 125?

I say we keep the entry in CREDITS (we /did/ use that code for quite
a while, even if we don't use it any more) and AUTHORS but ditch the
copyright entry, as it's not being used any more at all.

P

MestreLion

unread,
Apr 1, 2012, 6:29:58 PM4/1/12
to endgame-sin...@googlegroups.com
Done :)

Current branches of interest:
public/tel_aviv - "someone" forgot to update the Changelog ;)
public/update_es_AR - some kind soul provided a nice patch in issue #20
testing/i18n - so you can take a look and comment on my progress. DO NOT MERGE YET! (if you want to, just say and i'll "convert" it to a pubic/* branch

About the XDG branches... did you read my FIRST message on that topic? I'm afraid you missed it (I sent 2 emails on the same topic, you only commented on second)

You may fetch testing/i18n often, cos I'll push it frequently so you be aware of latest developments. Now I'll begin working on the _() function.

Phil Bordelon

unread,
Apr 1, 2012, 8:38:35 PM4/1/12
to endgame-sin...@googlegroups.com
On 04/01/2012 05:29 PM, MestreLion wrote:
> Done :)
>
> Current branches of interest:
> *public/tel_aviv* - "someone" forgot to update the Changelog ;)

I intentionally didn't make a Changelog entry. This isn't the sort
of thing that warrants an entry; it's not a meaningful bugfix or
feature. Obviously this is a judgment call of some sort, but what
I typically do before a release is add a sort of blanket 'Various
text tweaks and fixes (Phil)' entry and let that cover all of the
minor things I did.

> *public/update_es_AR* - some kind soul provided a nice patch in issue #20

I'll pull that in tonight.

> *testing/i18n* - so you can take a look and comment on my progress. DO NOT


> MERGE YET! (if you want to, just say and i'll "convert" it to a pubic/* branch
>
> About the XDG branches... did you read my FIRST message on that topic? I'm
> afraid you missed it (I sent 2 emails on the same topic, you only commented
> on second)

I /did/ read it. I'm still thinking about it :)

> You may fetch *testing/i18n* often, cos I'll push it frequently so you be


> aware of latest developments. Now I'll begin working on the _() function.

P

Reply all
Reply to author
Forward
0 new messages