Asyncify problems after update to 3.1.24

[Александр Гурьянов]

Hi, I updated js-dos project to use latest emscripten 3.1.24. But now even simpliest test didn't work. When I built it with -s ASSERTIONS=1 --profiling-funcs I have following error:

007591d2:0x63c1 Uncaught RuntimeError: unreachable
    at Normal_Loop() (.llvm.10015310407968227838) (007591d2:0x63c1)
    at DOSBOX_RunMachine() (007591d2:0x6c57)
    at CALLBACK_RunRealInt(unsigned char) (007591d2:0x92724)
    at DOS_Shell::Execute(char*, char*) (007591d2:0xe2e4e)
    at DOS_Shell::DoCommand(char*) (007591d2:0xda01d)
    at DOS_Shell::ParseLine(char*) (007591d2:0xd7fe3)
    at DOS_Shell::Run() (007591d2:0xd8724)
    at SHELL_Init() (007591d2:0xd9b16)
    at runRuntime (007591d2:0x14149f)
    at ret.<computed> (wdosbox.js:9:129411)

But all this functions already in asyncify lists, so I bisected and first bad commit is:

6a58eafa5dd62f26c6bc38d8bf0a55dee97b79ff is the first bad commit
commit 6a58eafa5dd62f26c6bc38d8bf0a55dee97b79ff
Author: chromium-autoroll <chromium...@skia-public.iam.gserviceaccount.com>
Date:   Tue Sep 13 23:04:38 2022 +0000

    Roll emscripten from ea154b19446b to fff3775abca4 (3 revisions)

    https://chromium.googlesource.com/external/github.com/emscripten-core/emscripten.git/+log/ea154b19446b..fff3775abca4

    2022-09-13 s...@chromium.org Don't pass `-fno-inline-functions` when `-Oz`/`-Os` are used (#17843)
    2022-09-13 7121787...@users.noreply.github.com [Proxying][NFC] Avoid unnecessary copies of std::function (#17834)
    2022-09-13 7121787...@users.noreply.github.com [WasmFS][NFC] Do not eagerly execute queue in ProxyWorker (#17835)

    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/emscripten-emscripten-releases
    Please CC wasm-wa...@grotations.appspotmail.com on the revert to ensure that a human
    is aware of the problem.

    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

    Tbr: wasm-wa...@grotations.appspotmail.com
    Change-Id: I217fac3bc67b0d69ff19fe04daae10f95d9d5f1e
    Reviewed-on: https://chromium-review.googlesource.com/c/emscripten-releases/+/3894706
    Commit-Queue: chromium-autoroll <chromium...@skia-public.iam.gserviceaccount.com>
    Bot-Commit: chromium-autoroll <chromium...@skia-public.iam.gserviceaccount.com>

 DEPS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

[Александр Гурьянов]

What is (.llvm.10015310407968227838)? Maybe problem is in signature of Normal_Loop()?

Normal_Loop() (.llvm.10015310407968227838)

пт, 14 окт. 2022 г. в 15:45, Александр Гурьянов <caii...@gmail.com>:

[Sam Clegg]

I would imagine the problem relates to the `-fno-inline-functions` change.  If you add that to your CFLAGS does the problem go away?

--
You received this message because you are subscribed to the Google Groups "emscripten-discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to emscripten-disc...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/emscripten-discuss/CAKOm%3DVFZs_S3KhUrMF-F7X1NkR3ytYQg%2BmrPQjkNLTCPejYFYw%40mail.gmail.com.

[Sam Clegg]

On Fri, Oct 14, 2022 at 5:46 AM Александр Гурьянов <caii...@gmail.com> wrote:

Hi, I updated js-dos project to use latest emscripten 3.1.24. But now even simpliest test didn't work. When I built it with -s ASSERTIONS=1 --profiling-funcs I have following error:

007591d2:0x63c1 Uncaught RuntimeError: unreachable
    at Normal_Loop() (.llvm.10015310407968227838) (007591d2:0x63c1)
    at DOSBOX_RunMachine() (007591d2:0x6c57)
    at CALLBACK_RunRealInt(unsigned char) (007591d2:0x92724)
    at DOS_Shell::Execute(char*, char*) (007591d2:0xe2e4e)
    at DOS_Shell::DoCommand(char*) (007591d2:0xda01d)
    at DOS_Shell::ParseLine(char*) (007591d2:0xd7fe3)
    at DOS_Shell::Run() (007591d2:0xd8724)
    at SHELL_Init() (007591d2:0xd9b16)
    at runRuntime (007591d2:0x14149f)
    at ret.<computed> (wdosbox.js:9:129411)

But all this functions already in asyncify lists, so I bisected and first bad commit is:

Is there something about the above error (or some other error you saw) that makes you think this is an asyncify issue?  I'm not saying it isn't, I'm just wondering how you know it is?

 

[Александр Гурьянов]

Yes this helps. But, how I make it work without this flag? I mean all functions already in asyncify list, but asyncify didn't work. Is it a bug or not?

сб, 15 окт. 2022 г. в 00:43, 'Sam Clegg' via emscripten-discuss <emscripte...@googlegroups.com>:

To view this discussion on the web visit https://groups.google.com/d/msgid/emscripten-discuss/CAL_va2-H5H2pPjpduyeGsJjifiehxJrgU-QLEs0eq8EtJxRVLA%40mail.gmail.com.

[Sam Clegg]

On Fri, Oct 14, 2022 at 11:41 PM Александр Гурьянов <caii...@gmail.com> wrote:

Yes this helps. But, how I make it work without this flag? I mean all functions already in asyncify list, but asyncify didn't work. Is it a bug or not?

It sounds like a bug, but I'm not familiar enough with ASYNCIFY to know.  Can you open an issue?

 

To view this discussion on the web visit https://groups.google.com/d/msgid/emscripten-discuss/CAKOm%3DVEDOzXBVvfTUPqgvyTpCLOSN%3DVjkXdS3T6X30G0Wr6w2w%40mail.gmail.com.