Issue 1130

[Punit Salian]

Hey guys, I am really interested in this project and looking to make my first contribution. I am looking at issue 1130 (emscripten_fetch calls onsuccess for url with non open port) . As a beginner to this project how should I start ? And what do I look for ?. Thanks

[Alon Zakai]

(I think you mean 11030, and not 1130?)

That would be great Punit!

The fetch code is in src/Fetch.js. Looking for onsuccess in that file is probably the fastest way to find the relevant code.

To get started you might want to first create a testcase that fails, so that you can see that it works after you fix things, and as you debug. Adding a testcase in the test suite is the best way I think, since then it's easy to run automatically, and you don't need to write a testcase later for the PR (but it does take a little more work up front). To do that, I would start by looking at testcases for the fetch API in the test suite, by searching for FETCH=0 in tests/*.py, or by searching under tests/ for the C fetch API calls (like emscripten_fetch). Then maybe there will be a test you can add to. (Test suite docs: https://emscripten.org/docs/getting_started/test-suite.html )

- Alon

On Wed, Jun 3, 2020 at 10:07 PM Punit Salian <salian...@gmail.com> wrote:

Hey guys, I am really interested in this project and looking to make my first contribution. I am looking at issue 1130 (emscripten_fetch calls onsuccess for url with non open port) . As a beginner to this project how should I start ? And what do I look for ?. Thanks

--
You received this message because you are subscribed to the Google Groups "emscripten-discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to emscripten-disc...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/emscripten-discuss/985facb6-69f6-4819-bb44-cd991b24ed14%40googlegroups.com.

[Punit Salian]

Hi Alon, Thanks for getting back.Surely let me look at Fetch.js   and go from there. I'll do add a testcase for this in test.py. If I do have any questions can I contact you ?

On Thursday, June 4, 2020 at 4:05:35 PM UTC-7, Alon Zakai wrote:

(I think you mean 11030, and not 1130?)

That would be great Punit!

The fetch code is in src/Fetch.js. Looking for onsuccess in that file is probably the fastest way to find the relevant code.

To get started you might want to first create a testcase that fails, so that you can see that it works after you fix things, and as you debug. Adding a testcase in the test suite is the best way I think, since then it's easy to run automatically, and you don't need to write a testcase later for the PR (but it does take a little more work up front). To do that, I would start by looking at testcases for the fetch API in the test suite, by searching for FETCH=0 in tests/*.py, or by searching under tests/ for the C fetch API calls (like emscripten_fetch). Then maybe there will be a test you can add to. (Test suite docs: https://emscripten.org/docs/getting_started/test-suite.html )

- Alon

On Wed, Jun 3, 2020 at 10:07 PM Punit Salian <salian...@gmail.com> wrote:

Hey guys, I am really interested in this project and looking to make my first contribution. I am looking at issue 1130 (emscripten_fetch calls onsuccess for url with non open port) . As a beginner to this project how should I start ? And what do I look for ?. Thanks

--
You received this message because you are subscribed to the Google Groups "emscripten-discuss" group.

To unsubscribe from this group and stop receiving emails from it, send an email to emscripten-discuss+unsub...@googlegroups.com.