On Maven and Suco

[xose]

Hello, emite-dev!

My name is José Martínez, I am a CS student from Spain and I'm going
to use Emite for my end of degree project.

To better integrate Emite on my project, I've done some changes to the
library: support for the Maven build system, removal of Suco and all
other deprecated methods, some API changes and code cleanup. All these
changes are now available on my GitHub:
https://github.com/xose/emite-fork

I contacted Dani last week about integrating those changes on upstream
Emite but, while all those changes were already planned for the Emite
project, he raised concerns that those using it in production would
have a hard time adapting to them, especially the removal of Suco. He
suggested introducing the changes step by step once the development
moved from Google Code to GitHub.

So now that the move is complete, I have thought of a way to introduce
all these changes without breaking production code. I'd like to hear
your comments and suggestions before I start doing anything though.

Step 1: create a v0.6 branch with the current code, and do a 0.6.0
release *now*. 0.6 has been in RC for a while, so introducing big
changes here is not a good idea. Those with production code can switch
to this branch for the time being. Any bugfixes will be backported to
this branch.

Step 2: add Maven support to both Emite and Hablar, update
dependencies (GWT 2.2, GIN 1.5) and clean up the code, but without
introducing any big API incompatibilities. We should also make sure
that all methods that depend on Suco have an alternative GIN
implementation, and Suco ones are marked as @Deprecated. Once this is
complete, we can create a v0.7 branch and do a 0.7.0 release. I think
we can aim for this 0.7 release by the end of March.

Step 3: Completely remove Suco and introduce all other API changes and
cleanups in the master branch. This will become 1.0 at some point, so
it should remain open for a while for it to stabilize, and maybe add
some new features.

This way, those with production code can stay on 0.6 and move to 0.7
with almost no code changes and still benefit from most of the
updates. Then they can start porting their code to GIN for when 1.0
gets released.

Thoughts?

-xose

[dani]

Hi Xose:

Thanks for your very well explained email.

I'm agree with all your thoughts and steps, even I just created the
0.6.0 branch (along the previous maven branch where all the step2 will
be implemented before merge it to master branch...)

May I help you with step2?

Saludos
Dani

[dani]

Hello:

I think i've configured github to send emails when commits, but it's
not working (any idea?)

Meanwhile, a couple of emails:

I've adapted the project structure to maven in the maven branch:
https://github.com/EmiteGWT/emite/tree/maven

This is the commit:
https://github.com/EmiteGWT/emite/commit/0bfb3d021f443439862a15d0e8db8bdfd552c403

Also I've started a new WikiPage:
https://github.com/EmiteGWT/emite/wiki/Emite-and-Maven

Currently maven is NOT working, but I hope it do it soon.

Saludos,
Dani

[Vicente J. Ruiz Jurado]

El 15/03/11 18:57, dani escribi�:

> I think i've configured github to send emails when commits, but it's
> not working (any idea?)

No idea, but in hooks I've changed:
emit...@googlegroups.com.
to
emit...@googlegroups.com

(a final dot in a domain normally it's ok, but maybe it's related )

Bests,
--
Vicente

[Ashley Ward]

I've added a Roadmap document to the emite wiki :
https://github.com/EmiteGWT/emite/wiki/Roadmap

It's essentially as Jose recommended (which sounded very sensible!). Can
you all have a look and feel free to alter as appropriate.

I haven't mentioned anything about hablar in it - I'll add a roadmap for
hablar which fits in (especially around the move to Gin)

Cheers!

Ash

[dani]

Hello:

Just a little thing: the Suco stuff is deprecated since some (long) time ago... So I think in the new 0.7.0 version should be removed (also I've removed the Suco dependencies on Hablar in the nosuco branch):

https://github.com/EmiteGWT/hablar/tree/nosuco

So I think we are ready to remove it...

I like the new RoadMap wiki page ;) and, yes, maybe we should include Hablar (or maybe create another one for the other project).

How does it sounds to you?

Saludos

Dani

--
You received this message because you are subscribed to the Google Groups "emite-dev" group.
To post to this group, send email to emit...@googlegroups.com.
To unsubscribe from this group, send email to emite-dev+...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/emite-dev?hl=en.

[Ashley Ward]

Excellent job removing the suco dependency from hablar!

 

I suppose I’m a little worried about the amount of work we will have in porting our (surevine’s) code to gin as, although our codebase is quite small, I have a feeling that some of the features of Suco we are using will be non-trivial to replicate using gin.

 

But having said that, I think we need to move forward so I’ll agree with you – we should remove suco and we may as well do it sooner rather than later! I’ll update the roadmap…

 

Cheers,

 

Ash

[xose]

Hello,

Today I finished porting Emite to Maven. The changes are on my github,
ready to be pulled. To summarize:

- New Eclipse project using m2eclipse, and fixes to the Maven POM.
- xmltools is downloaded from Maven, no need to use that hack to get it working.
- Moved all the tests to the test folder, and xml files to resources.
- Some updates on dependency versions.
- Other minor fixes.

A couple of tests are currently failing. Until they get fixed, run
"mvn package -DskipTests=true" to compile and build the jar.

I think that with all these changes Maven support is complete, so we
should consider merging the maven branch into master and start
updating other parts of the code. We must also decide if we keep Suco
for v0.7 or remove it.

Tomorrow I'll take a look at Hablar to mavenize it.

-xose

[xose]

I just added Maven support to Hablar on my repo and sent a pull
request. It's still not complete, but it works.

When both Emite and Hablar branches are merged into master, we can
start doing other updates.

-xose

[xose]

I created 2 new branches on both of my repos:

nosuco: builds on top of the maven branch, and removes all Suco
dependencies. It also contains an updated Storage XEP, required
because of the Suco removal. The nosuco branch of hablar has updates
to use the new Storage system, as well as removing the last Suco
dependencies.

updates: to be applied after nosuco, contains updates to deprecated
methods on GWT, as well as some other fixes.

Most Emite tests are currently failing, due to them being dependent on
Suco. I haven't had time to fix them, so if someone that knows the
tests and the library better than I do could update them, that would
be great. I'll do some more changes to the updates branch in the
meantime.

When the tests are updated and all changes merged into main, I think
we should be ready to do that 0.7 release.

-xose

[xose]

Hello,

I updated and fixed most of the Emite tests. There are a few that are
still failing though, I think due to the new xmltools version.

I sent new pull requests with all these updates to both emite and hablar.

-xose

[Ashley Ward]

Thanks xose,

I'll get those pulled in when I get a spare minute!

Ash

-----Original Message-----
From: emit...@googlegroups.com [mailto:emit...@googlegroups.com] On
Behalf Of xose
Sent: 03 April 2011 04:06
To: emit...@googlegroups.com
Subject: Re: [emite-dev] On Maven and Suco

Hello,

-xose

--