Issue 350 in emite: possibly bug in XmppBoshConnection on connection failure

5 views
Skip to first unread message

em...@googlecode.com

unread,
May 24, 2011, 9:21:54 AM5/24/11
to emit...@googlegroups.com
Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 350 by bernd.roessl: possibly bug in XmppBoshConnection on
connection failure
http://code.google.com/p/emite/issues/detail?id=350

If emite is not able to connect to the backend it will do 8 retries with an
increasing delay (see RetryControl) as long as the error count does not get
reset. Each time emite handles a resonse in XmppBoshConnection it will
reset the error count and so RetryControl will not do it's purpose.

What steps will reproduce the problem?
1. you need a unresponsive jabber server behind responsive reverse proxy
2. try to connect to jabber server
3. reverse proxy will responde with status 502

What is the expected output? What do you see instead?

emite should try to connect 8 times with more delay on each retry. But
instead it retries forever with a delay of 500ms.

If clearErrors(); will be done just on a successful response the onError
handler will pass a proper error-count to RetryControl.

em...@googlecode.com

unread,
Aug 19, 2011, 5:53:53 AM8/19/11
to emit...@googlegroups.com

Comment #1 on issue 350 by Fabrice....@gmail.com: possibly bug in
XmppBoshConnection on connection failure
http://code.google.com/p/emite/issues/detail?id=350

Hi,

I've worked a bit on this and made a patch. Please find it attached.
(worked on the master)

Attachments:
issue350.patch 1.8 KB

em...@googlecode.com

unread,
Aug 19, 2011, 6:15:21 AM8/19/11
to emit...@googlegroups.com

Comment #2 on issue 350 by roe...@lovelysystems.com: possibly bug in
XmppBoshConnection on connection failure
http://code.google.com/p/emite/issues/detail?id=350

what is the reason for changing SessionStates.ready to
SessionStates.loggedIn? if a connection get resumed we will not
get 'loggedIn' but 'ready'.


em...@googlecode.com

unread,
Aug 30, 2011, 4:50:59 AM8/30/11
to emit...@googlegroups.com

Comment #3 on issue 350 by Fabrice....@gmail.com: possibly bug in
XmppBoshConnection on connection failure
http://code.google.com/p/emite/issues/detail?id=350

but if the connection is not resumed but re-established (as it happens in
this scenario) you will not get 'ready'

em...@googlecode.com

unread,
Aug 30, 2011, 4:54:59 AM8/30/11
to emit...@googlegroups.com

Comment #4 on issue 350 by Fabrice....@gmail.com: possibly bug in
XmppBoshConnection on connection failure
http://code.google.com/p/emite/issues/detail?id=350

By the way I'm a bit confused about where to have this discussion: should
we discuss on google code or GitHub ?

em...@googlecode.com

unread,
Aug 30, 2011, 1:04:28 PM8/30/11
to emit...@googlegroups.com

Comment #5 on issue 350 by danigb: possibly bug in XmppBoshConnection on
connection failure
http://code.google.com/p/emite/issues/detail?id=350

Sorry Fabrice... we are a little bit stalled... I'm currently on
holidays... we are moving to github and I hope we can look at this issue
soon...

Meanwhile, any patch is welcomed ;)

Bests, dani


Reply all
Reply to author
Forward
0 new messages