--
You received this message because you are subscribed to the Google Groups "elixir-lang-core" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elixir-lang-core+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/elixir-lang-core/CAM_eapis0_a16Z6HqptYtc2ekCQ46-eh_uzHZtQYkfQ1yHE%2B2g%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
+1 from me!
On Mon, Feb 13, 2017 at 4:49 PM, Eric Meadows-Jönsson <eric.meado...@gmail.com> wrote:
Currently struct and map keys are in indeterminate order when they are inspected. Due to implementation details in the VM maps that have <32 keys are in term order but for larger maps and structs the order is random.I propose always sorting the map keys when they are inspected so that it's easier to read and scan the results.--Eric Meadows-Jönsson
--
You received this message because you are subscribed to the Google Groups "elixir-lang-core" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elixir-lang-co...@googlegroups.com.
And who does read any documentation when he sees the same output on the cli every time? Documenting the behaviour hasn't helped for charlists either...
To view this discussion on the web visit https://groups.google.com/d/msgid/elixir-lang-core/49866d3d-07fb-4218-b537-860d0bbb546c%40googlegroups.com.
To unsubscribe from this group and stop receiving emails from it, send an email to elixir-lang-core+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/elixir-lang-core/49866d3d-07fb-4218-b537-860d0bbb546c%40googlegroups.com.
Beautiful is
better than ugly,
Explicit is better than implicit,
Simple is better than complex,
Complex is better than complicated.
The Zen of Python, by Tim Peters
To unsubscribe from this group and stop receiving emails from it, send an email to elixir-lang-core+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/elixir-lang-core/2d64f24b-df25-4644-acd6-f5d5633ea720%40googlegroups.com.
+1 Eric
======================================================= I welcome VSRE emails. Learn more at http://vsre.info/ =======================================================
--
You received this message because you are subscribed to the Google Groups "elixir-lang-core" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elixir-lang-core+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/elixir-lang-core/934ffbee-44a6-40fb-9ecf-e24d48624f3f%40googlegroups.com.
--
You received this message because you are subscribed to a topic in the Google Groups "elixir-lang-core" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/elixir-lang-core/Lc2fWthKQSM/unsubscribe.
To unsubscribe from this group and all its topics, send an email to elixir-lang-core+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/elixir-lang-core/CAJr6D4S81ZqQ%2BaZQrw_rohpPXxwBpUWz1WsAEUZ82fjT02U7Pg%40mail.gmail.com.
Before jumping on this should we be asking why the decision was made to not sort if there are more than 32 keys? Maybe there is a performance concern, and if we want sorted keys we should be sending a different message?Amos KingOwnerBinary Nogginhttp://binarynoggin.com #businesshttp://thisagilelife.com #podcast======================================================= I welcome VSRE emails. Learn more at http://vsre.info/ =======================================================
On Tue, Feb 14, 2017 at 7:41 PM, Ben Wilson <benwil...@gmail.com> wrote:
This has my vote as well. It would make visually inspecting maps a lot easier.
On Tuesday, February 14, 2017 at 7:36:05 PM UTC-5, Onorio Catenacci wrote:+1 Eric
--
You received this message because you are subscribed to the Google Groups "elixir-lang-core" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elixir-lang-co...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/elixir-lang-core/934ffbee-44a6-40fb-9ecf-e24d48624f3f%40googlegroups.com.
--
You received this message because you are subscribed to the Google Groups "elixir-lang-core" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elixir-lang-co...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/elixir-lang-core/CAJr6D4S81ZqQ%2BaZQrw_rohpPXxwBpUWz1WsAEUZ82fjT02U7Pg%40mail.gmail.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/elixir-lang-core/968dfad6-6889-4975-a413-91bbc48968ed%40googlegroups.com.
I believe it would be useful to not sort if there are very many keys as well. A huge map would presumably be inspected in a short while, skipping keys after the first few. Inspecting a huge map could become cpu/memory intensive, which I would find surprising... anyways +1 from me
--
You received this message because you are subscribed to the Google Groups "elixir-lang-core" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elixir-lang-core+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/elixir-lang-core/8a1f314b-efdb-468d-8dae-ba6492aa0f95%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to a topic in the Google Groups "elixir-lang-core" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/elixir-lang-core/Lc2fWthKQSM/unsubscribe.
To unsubscribe from this group and all its topics, send an email to elixir-lang-core+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/elixir-lang-core/5e3f4e37-bb6c-4688-bb86-5d430e095726%40googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/elixir-lang-core/2649817D-21D7-4C50-B477-7038486C9849%40gmail.com.
My guess is that the sorting time will be insignificant compared to sending the data down your logging infrastructure regardless if it's just printing to a terminal or if it's sending data over a socket. Both require syscalls and IO which is usually the more time consuming part.I think it's wrong to prioritize performance instead of usability for Inspect since the functionality is made for humans. If performance actually is more important than readability then there are lots of optimizations we can do to Inspect, for example dropping algebra documents and pretty printing.
On Wed, Feb 15, 2017 at 10:04 PM, Dmitry Belyaev <be.d...@gmail.com> wrote:
If I dump a map to logs I don't care about its order, I only want it to be as fast as possible. Logging already introduces a serious performance hit, and sorting would make logging even more expensive performance wise.
As was mentioned previously if a map is small it's already sorted. So it would be a waste of time although insignificant. But if it's huge it would spend both cpu and memory to vuild sorted structure, and later would spend more cpu on its garbage collection. I don't like the idea of losing production performance only for development convenience.
On 16 February 2017 07:25:51 GMT+11:00, Bruce Tate <br...@rapidred.com> wrote:
Good points, but isn't inspecting a map generally a development time activity? Especially big maps?Sometimes, optimizing people is the right thing to do. When you're looking at big lists of ecto objects and working to pick out an ID, having things in order is a big deal.-bt
On Wed, Feb 15, 2017 at 2:17 PM, Tallak Tveide <tal...@gmail.com> wrote:
I believe it would be useful to not sort if there are very many keys as well. A huge map would presumably be inspected in a short while, skipping keys after the first few. Inspecting a huge map could become cpu/memory intensive, which I would find surprising... anyways +1 from me
--
You received this message because you are subscribed to the Google Groups "elixir-lang-core" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elixir-lang-co...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/elixir-lang-core/8a1f314b-efdb-468d-8dae-ba6492aa0f95%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--Bruce Tate
President, RapidRed, LLC
Phone: 512.772.4312
Fax: 512 857-0415
Author of Seven Languages in Seven Weeks, Deploying Rails Applications, From Java to Ruby, Rails: Up and Running, Beyond Java, 6 others.
--
You received this message because you are subscribed to the Google Groups "elixir-lang-core" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elixir-lang-co...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/elixir-lang-core/2649817D-21D7-4C50-B477-7038486C9849%40gmail.com.
--Eric Meadows-Jönsson
To view this discussion on the web visit https://groups.google.com/d/msgid/elixir-lang-core/3dbae292-3978-41d3-bb54-3b006d694260%40googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/elixir-lang-core/84ad4498-7e76-4306-a925-83609bbaf128%40googlegroups.com.
To unsubscribe from this group and stop receiving emails from it, send an email to elixir-lang-core+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/elixir-lang-core/84ad4498-7e76-4306-a925-83609bbaf128%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups "elixir-lang-core" group.
To view this discussion on the web visit https://groups.google.com/d/msgid/elixir-lang-core/E3BFEF00-7475-4716-8525-8B8BE1A4419B%40sorentwo.com.To unsubscribe from this group and stop receiving emails from it, send an email to elixir-lang-core+unsubscribe@googlegroups.com.
--
You received this message because you are subscribed to a topic in the Google Groups "elixir-lang-core" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/elixir-lang-core/Lc2fWthKQSM/unsubscribe.
To unsubscribe from this group and all its topics, send an email to elixir-lang-core+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/elixir-lang-core/84ad4498-7e76-4306-a925-83609bbaf128%40googlegroups.com.
--
You received this message because you are subscribed to a topic in the Google Groups "elixir-lang-core" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/elixir-lang-core/Lc2fWthKQSM/unsubscribe.
To unsubscribe from this group and all its topics, send an email to elixir-lang-core+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/elixir-lang-core/84ad4498-7e76-4306-a925-83609bbaf128%40googlegroups.com.
I'm concerned about the logging case for large maps. I propose just increasing the threshold to something practically high, but low enough that performance is predictable.
To unsubscribe from this group and all its topics, send an email to elixir-lang-co...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/elixir-lang-core/84ad4498-7e76-4306-a925-83609bbaf128%40googlegroups.com.
--
You received this message because you are subscribed to the Google Groups "elixir-lang-core" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elixir-lang-co...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/elixir-lang-core/CAHfREDXUsLtBSyuw0OunChCCY3bFPdufzqwbSgBF%2BD9pqaoo6w%40mail.gmail.com.
To unsubscribe from this group and all its topics, send an email to elixir-lang-core+unsubscribe@googlegroups.com.
--To view this discussion on the web visit https://groups.google.com/d/msgid/elixir-lang-core/84ad4498-7e76-4306-a925-83609bbaf128%40googlegroups.com.
You received this message because you are subscribed to the Google Groups "elixir-lang-core" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elixir-lang-core+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/elixir-lang-core/CAHfREDXUsLtBSyuw0OunChCCY3bFPdufzqwbSgBF%2BD9pqaoo6w%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups "elixir-lang-core" group.
To view this discussion on the web visit https://groups.google.com/d/msgid/elixir-lang-core/CAOMhEnxQajyNp9-XX4P5%3D7Eu5VA_CGSWZ1SHzGVSH9gH6vin5g%40mail.gmail.com.To unsubscribe from this group and stop receiving emails from it, send an email to elixir-lang-core+unsubscribe@googlegroups.com.