pattern matching record from its own module

[Saša Jurić]

As I mentioned elsewhere, I have a habit of extending records with my own functions.

When I pattern match a record in the same module I do following:

defrecord MyRecord ... do

  def fun(__MODULE__[...]) ...

end

instead of 

defrecord MyRecord ... do

  def fun(MyRecord[...]) ...

end

I wanted to verify is there any downside to this? Any reason why I shouldn't do it?

[José Valim]

Both formats should be fine. :)

José Valim

www.plataformatec.com.br

Skype: jv.ptec

Founder and Lead Developer

--
You received this message because you are subscribed to the Google Groups "elixir-lang-core" group.
To unsubscribe from this group and stop receiving emails from it, send an email to elixir-lang-co...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

[ILYA Khlopotov]

>> Both formats should be fine. :)

Actually 'def fun(MyRecord[...])' not always work. For example it doesn't work for nested modules:

defmodule CCCC do

  defrecord State, [ignore: [], path: []] do

    def ignore(State[path: path, ignore: patterns]) do

      true

    end

  end

end

This code would work from iex but wouldn't when you try to compile module from file:

bin/elixirc tt.ex

== Compilation error on file tt.ex ==

** (RuntimeError) expected module State to be loaded and defined

    elixir/lib/elixir/lib/kernel.ex:2963: Kernel."MACRO-access"/3

    tt.ex:6: Kernel.access/2

However I think this must be a bug.

Best regards,

ILYA

[José Valim]

Please open up an issue in the issues tracker?

José Valim

www.plataformatec.com.br

Skype: jv.ptec

Founder and Lead Developer