11,000 lines of code deleted

13 views
Skip to first unread message

Jack Poulson

unread,
Jul 4, 2013, 3:44:04 AM7/4/13
to elemen...@googlegroups.com
Dear all,

I finally removed all versions of routines which exploit the fact that the phases of real/proper Householder transformations do not need to be explicitly stored. This was causing a large amount of redundancy in the library, as real and complex versions of routines would have slightly different syntax and involve large copy and pastes with minimal modifications. The worst offenders were HermitianTridiag and Bidiag.

The result is that more than 11,000 lines of code were just removed without giving up any functionality. See:
https://github.com/poulson/Elemental/commit/503bd7b5fb82501a5fbb0534221d5f9f77989789

src/lapack-like/HermitianEig.cpp also deserves to be compressed a bit.

Jack
Reply all
Reply to author
Forward
0 new messages