Large Forward Open

[John Arvanitis]

Hello again

Does opener support Large Forward Open msgs?

J.A.

[Martin Melik-Merkumians]

Hi,

currently, not, but in principle the code is ready to process Large Forward Open Requests.

If this is needed, I can put it on my development plan, but I am currently working also on other features, such aus CIP Security, so I am not sure when I will be able to add this to the code.

Best regards,

Martin

[John Arvanitis]

We need this feature for our imlementation ASAP.

How difficult is to implemented it?

Could you please provide us with guidelines in order to do it?

//Best Regards

//J.A. 

[Martin Melik-Merkumians]

Hi,

it should be comparatively simple, as the connection objects should already be able to save the parameters.

First you have to insert a new service 5B into the connection manager. Most of the decoding code from the forward open request can be reused, only from O to T Network Connection Parameters on, the correct data lengths at the correct positions have to be decoded (see Vol. 1 Table 3-5.17).

I think you can even reuse the remainder of the forward open handling code, as it only uses the data saved in the corresponding connection object.

Best regards,

Martin

[John Arvanitis]

Hi Martin .

First of all Happy new Year

1) We have implemented LFO functionality into Opener and now we are testing it.

It seems that it is working fine with our Noname Scanner.  

If you would like we can share our code in order to be able do a deeper testing (using cpputest).

Unfortunately our Noname scanner seems to have some incompatibilities and we have modified a little bit your code.

I am in your disposal for a possible contribution. 

2) In CMakelists file you have define the constant OPENER_CONSUMED_DATA_HAS_RUN_IDLE_HEADER

I assume that some scanners shall not remove the overhead of 4 bytes RUN/IDLE header in case of non heartbeat O->T packet. This is the reason that 

you provide the ability to set this variable before compilation.

Is this correct?

In case of heartbeat we assume that size in parameters does not contain these 4 bytes. Where is this definition on CIP spec?

See file cipioconnection.c line 146. In our Noname scanner we got in Forward open parameters content size 4 more bytes.

In order to be able to play with it we change the code as you see bellow

#ifdef OPENER_CONSUMED_DATA_HAS_RUN_IDLE_HEADER

if ( (data_size > 0)){// && (!is_heartbeat) ) { iarv CIP incompatibility?

/* we only have an run idle header if it is not an heartbeat connection */

data_size -= 4; /* remove the 4 bytes needed for run/idle header */

diff_size += 4;

}

#endif  

//Best Regards 

//J.A.

[Martin Melik-Merkumians]

Hi John,

sorry for the very late reply. Getting your code would be great!

2) In CMakelists file you have define the constant OPENER_CONSUMED_DATA_HAS_RUN_IDLE_HEADER

I assume that some scanners shall not remove the overhead of 4 bytes RUN/IDLE header in case of non heartbeat O->T packet. This is the reason that 

you provide the ability to set this variable before compilation.

Is this correct?

This is part of the EDS description. If I am not wrong, each device can decide if it provides this header. In the OpENer EDS description we declare, that we use it. I would have to check if this is mandatory for some cases.

In case of heartbeat we assume that size in parameters does not contain these 4 bytes. Where is this definition on CIP spec?

I have to check this, as this is quite old code, written by some of my predecessors in OpENer development.

Best regards,

Martin 

[Alois Zoitl]

Hi,

also sorry I wanted to write about the heartbeat as well. As I remember it should be part of the Ethernet encap spec or mentioned in Pub 70.

BR,
Alois

> --
> You received this message because you are subscribed to the Google Groups "EIP Stack Group OpENer Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to eip-stack-group-opener...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/eip-stack-group-opener-developers/679b338a-43a9-4589-b32e-969d0b08e6a4%40googlegroups.com.

[John Arvanitis]

I can send you the code as a zip file on Dropbox. Is it ok?

[Martin Melik-Merkumians]

Hi,

Sure thats ok

[John Arvanitis]

Can I have your email?

[Vincent Prince]

Hi,

I'm also interested in Large Forward Open feature, do you know if this will be integrated ?

I can help creating github PR from your patch if needed.

Best regards,

Vincent

[John Arvanitis]

I have change a little nit the original code . Please remove all iarv comments if you want

[John Arvanitis]

Send me your email . i try to import the file but I am failed

Τη Παρασκευή, 15 Μαΐου 2020 - 10:35:36 π.μ. UTC+3, ο χρήστης Vincent Prince έγραψε:

[Vincent Prince]

Hi John,

Did you receive it? Otherwise it's vincent.prince.fr[at]gmail.com.

Best regards,

Vincent