Memory analyzer void safety updates at github

12 views
Skip to first unread message

Anders Persson

unread,
Mar 21, 2014, 5:49:50 AM3/21/14
to eiffelst...@googlegroups.com
Hi

I have added my changes to github for review and to make it eassier for me and Victorien to collaborate since memeory analyzer library is dependent on the graph library.

You can find the code at:


and the changes are best viewed at


Unfortunatelly even if some changes are minor the diffs presented by github is big. It is when I have added if-statements like

if attached...


Regards

Anders

Emmanuel Stapf

unread,
Mar 27, 2014, 5:20:34 PM3/27/14
to eiffelst...@googlegroups.com
Even though it is not perfect, we will use https://codereview.appspot.com/ for reviewing the code. Can you submit your patch there?

Thanks,
Manu

Anders Persson

unread,
Mar 27, 2014, 5:26:41 PM3/27/14
to eiffelst...@googlegroups.com
Hi

I will probably be able to do it tomorrow.

Anders


--
For more messaging options, visit this group at http://forum.eiffel.com.
Information on the Eiffelstudio project: http://dev.eiffel.com.

Anders Persson

unread,
Mar 28, 2014, 12:13:06 PM3/28/14
to eiffelst...@googlegroups.com
Hi

I am not sure, after reading the documentation, which way is best to upload a patch. How have you done it, used upload.py? Could you write an example command row how you do it?

Is it possible to upload anything without installing python?

Regards

Anders

Emmanuel Stapf

unread,
Mar 28, 2014, 12:19:14 PM3/28/14
to eiffelst...@googlegroups.com

You do not have much choice on that, but if you send me the svn diff results, I can upload it for you.

 

Regards,

Manu

 

--

Anders Persson

unread,
Mar 28, 2014, 12:40:39 PM3/28/14
to eiffelst...@googlegroups.com
Hi

I have sent you a patch.

Anders

Emmanuel Stapf

unread,
Mar 28, 2014, 1:13:39 PM3/28/14
to eiffelst...@googlegroups.com

I’ve uploaded the patch. Can you check that you have access to:

 

https://codereview.appspot.com/81910043/

 

Manu

 

From: eiffelst...@googlegroups.com [mailto:eiffelst...@googlegroups.com] On Behalf Of Anders Persson
Sent: Friday, March 28, 2014 09:13
To: eiffelst...@googlegroups.com
Subject: [EiffelStudio Dev] Re: Memory analyzer void safety updates at github

 

Hi

--

Anders Persson

unread,
Mar 28, 2014, 1:27:23 PM3/28/14
to eiffelst...@googlegroups.com
I can access it. Thanks

Anders
Reply all
Reply to author
Forward
0 new messages