Libcurl 8.5.0 in Github repository

[Thomas Goering]

The change log of EiffelStudio 24.05 includes this:

• Eiffel cURL: updated to version 8.5.0 of libcurl.

This is done with commit c98cd6d in the Github EiffelStudio repository and it includes three files that are normally generated during compilation of the library. And this is my point in my comment which I added to that commit:

https://github.com/EiffelSoftware/EiffelStudio/commit/c98cd6d65af178001e9f390cfdaf06893f3615a1#commitcomment-153622124

---

What's the reason for adding these files to the repository?

Src/C_library/curl/winbuild/CURL_OBJS.inc
‎Src/C_library/curl/winbuild/LIBCURL_OBJS.inc
‎Src/C_library/curl/winbuild/vc140.idb

They are created during the compilation of the libraries anyhow, aren't they?

In addition to that, in the .inc files my local compilation creates different output like this (-dll- is changed to -static-):

File in repository contains lines like: ..\builds\libcurl-vc-x64-release-dll-ipv6-sspi-schannel-obj-curl/slist_wc.obj 
Locally built file contains lines like: ..\builds\libcurl-vc-x64-release-static-ipv6-sspi-schannel-obj-curl/slist_wc.obj \

So, there's a difference in what's checked in to the repository and what is compiled using the files in the repository. Does this make an important difference?

---

I thought I post it here because I don't know if such comments are read...

[Javier Velilla]

Hi Thomas

These files were mistakenly included in the repository and are not necessary. They have already been removed from the latest source code as of April 18th.
You can verify the changes in the following update https://github.com/EiffelSoftware/libraries/commit/e589b36fab255e45b26ca87bacbce768226930ae

-- Javier

[Thomas Goering]

Thanks! I didn't compare with the libraries repository.

Thomas