[PATCH 1/2] kernel-stub: only warn if device part uuid variable cannot be set

[Felix Moessbauer]

We got reports from the field stating that the boot failed because the
efi variables could not be set and we bail out in this case. As the
systemd boot protocol is not a mandatory feature, we can safely ignore
this case. This is in line with the implementation in systemd-boot.

We now change the bail-out to an error message without bail-out.

Fixes: 7c90e82 ("efi: implement systemd boot loader interface")
Reported-by: Jan Kiszka <jan.k...@siemens.com>
Signed-off-by: Felix Moessbauer <felix.mo...@siemens.com>
---
main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/main.c b/main.c
index 3885754..f0b9aa0 100644
--- a/main.c
+++ b/main.c
@@ -192,8 +192,8 @@ EFI_STATUS efi_main(EFI_HANDLE image_handle, EFI_SYSTEM_TABLE *system_table)
bg_interface_params.loader_device_part_uuid = boot_medium_uuidstr;
status = set_bg_interface_vars(&bg_interface_params);
if (EFI_ERROR(status)) {
- error_exit(L"Cannot set bootloader interface variables",
- status);
+ ERROR(L"Cannot set bootloader interface variables (%r)\n",
+ status);
}
INFO(L"LoaderDevicePartUUID=%s\n", boot_medium_uuidstr);
FreePool(boot_medium_uuidstr);
--
2.49.0

[Jan Kiszka]

Would we rather a WARNING now.

Jan

> }
> INFO(L"LoaderDevicePartUUID=%s\n", boot_medium_uuidstr);
> FreePool(boot_medium_uuidstr);


--

Siemens AG, Foundational Technologies
Linux Expert Center