[meta-efibootguard] Re: The patch below

11 views
Skip to first unread message

dmitri....@litmusautomation.com

unread,
Jan 31, 2018, 4:00:54 PM1/31/18
to EFI Boot Guard
HI,

The patch below is to start branch `morty` from current master. It only took me to revert one commit to switch back to the older version of wic and I was able to produce an image with poky-morty with it.

So, could you please create `morty` branch in your github repository from current `master` and apply this patch to it.

I can alternatively send pull request via github.


Regards,

Dmitri Toubelis
Head of Engineering @ Litmus Automation

Jan Kiszka

unread,
Jan 31, 2018, 4:18:14 PM1/31/18
to dmitri....@litmusautomation.com, EFI Boot Guard, Andreas Reichel
On 2018-01-31 22:00, dmitri....@litmusautomation.com wrote:
> HI,
>
> The patch below is to start branch `morty` from current master. It only
> took me to revert one commit to switch back to the older version of wic
> and I was able to produce an image with poky-morty with it.

Did you also test it successfully?

In any case, some ack from Andreas would be good.

>
> So, could you please create `morty` branch in your github repository
> from current `master` and apply this patch to it.
>
> I can alternatively send pull request via github.

Patch on the list is indeed the preferred path.

Thanks,
Jan

--
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux

Jan Kiszka

unread,
Jan 31, 2018, 4:34:16 PM1/31/18
to Dmitri Toubelis, efibootguard-dev
[re-adding the list]

On 2018-01-31 22:29, Dmitri Toubelis wrote:
> Hi Jan,
>
> I was only able to test the build process and I got as far as booting
> the system, entering EFI shell and verifying configuration of all
> partitions.
>
> My environment is missing one of the required watchdog driver, so I was
> unable to test it all the way through. It would be the best to run it
> all the way through and I wonder if you would have suitable environment
> on your end for this. I still need to figure out the driver issue before
> I can move any further.
>
> In essence, this patch is just revert of a single commit related to
> `wic` version, so I did not add any code of my onn, all I've done is
> `git revert` for this particular patch.

Looking through Andreas' series again, you are probably right from a
functional perspective. Then we should just update the git references in
the README as well.

Thanks,
Jan

>
> Regards,
>
> Dmitri Toubelis
> Head of Engineering @ Litmus Automation
> dmitri....@litmusautomation.com

dmitri....@litmusautomation.com

unread,
Feb 1, 2018, 1:12:12 AM2/1/18
to EFI Boot Guard
I've just managed to boot the image, so everything checks - I was able to build an image with poky morty and I was able to boot it too.
Reply all
Reply to author
Forward
0 new messages