[meta-efibootguard][PATCH] Rename base package to efibootguard

12 views
Skip to first unread message

Pascal Bach

unread,
Aug 30, 2018, 10:02:43 AM8/30/18
to efibootg...@googlegroups.com, Pascal Bach
When setting the EFI_PROVIDER variable two things are expected:

1. A package with the name ${EFI_PROVIDER} exists that is included in
packagegroup-core-boot
2. A bbclass with the name ${EFI_PROVIDER} exists

With the current layer there is a class called efibootguard but the package is
called efibootguard-efi. These do not match.

This renames the base package to efibootguard to match the class name.
This is also in line with how systemd-boot and grub-efi work.

Signed-off-by: Pascal Bach <pasca...@siemens.com>
---
recipes-bsp/efibootguard/efibootguard.bb | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/recipes-bsp/efibootguard/efibootguard.bb b/recipes-bsp/efibootguard/efibootguard.bb
index 3449fda..7d1081e 100644
--- a/recipes-bsp/efibootguard/efibootguard.bb
+++ b/recipes-bsp/efibootguard/efibootguard.bb
@@ -28,7 +28,7 @@ PACKAGES = "${PN}-tools-dbg \
${PN}-tools-staticdev \
${PN}-tools-dev \
${PN}-tools \
- ${PN}-efi"
+ ${PN}"

EXTRA_OECONF = "--with-gnuefi-sys-dir=${STAGING_DIR_HOST} \
--with-gnuefi-include-dir=${STAGING_INCDIR}/efi \
@@ -38,7 +38,7 @@ FILES_${PN}-tools = "${bindir}"
FILES_${PN}-tools-dbg = "/usr/src/debug ${bindir}/.debug /usr/lib/debug"
FILES_${PN}-tools-staticdev = "${libdir}/lib*.a"
FILES_${PN}-tools-dev = "${includedir}/${BPN}"
-FILES_${PN}-efi = "${libdir}/${BPN}"
+FILES_${PN} = "${libdir}/${BPN}"

do_deploy () {
install ${B}/efibootguard*.efi ${DEPLOYDIR}
--
2.11.0

Jan Kiszka

unread,
Aug 30, 2018, 10:22:26 AM8/30/18
to [ext] Pascal Bach, efibootg...@googlegroups.com, Andreas Reichel
Andreas, any concerns from your side?

Jan

--
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux

Andreas Reichel

unread,
Aug 30, 2018, 10:24:39 AM8/30/18
to [ext] Jan Kiszka, [ext] Pascal Bach, efibootg...@googlegroups.com, Andreas Reichel
I look at it tomorrow, no time atm.
>
> Jan
>
> --
> Siemens AG, Corporate Technology, CT RDA IOT SES-DE
> Corporate Competence Center Embedded Linux
>
> --
> You received this message because you are subscribed to the Google Groups "EFI Boot Guard" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to efibootguard-d...@googlegroups.com.
> To post to this group, send email to efibootg...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/efibootguard-dev/3b4751df-a5f9-4e52-13a8-06c1da1d2c8a%40siemens.com.
> For more options, visit https://groups.google.com/d/optout.

--
Andreas Reichel
Dipl.-Phys. (Univ.)
Software Consultant

Andreas...@tngtech.com, +49-174-3180074
TNG Technology Consulting GmbH, Betastr. 13a, 85774 Unterfoehring
Geschaeftsfuehrer: Henrik Klagges, Dr. Robert Dahlke, Gerhard Mueller
Sitz: Unterfoehring * Amtsgericht Muenchen * HRB 135082

Andreas Reichel

unread,
Aug 31, 2018, 7:45:35 AM8/31/18
to [ext] Jan Kiszka, [ext] Pascal Bach, efibootg...@googlegroups.com, Andreas Reichel
> > > -FILES_${PN}-efi = "${libdir}/${BPN}"
> > > +FILES_${PN} = "${libdir}/${BPN}"

Looks good to me.

Andreas
> > > do_deploy () {
> > > install ${B}/efibootguard*.efi ${DEPLOYDIR}
> > >
> >

Jan Kiszka

unread,
Aug 31, 2018, 8:16:14 AM8/31/18
to [ext] Pascal Bach, efibootg...@googlegroups.com
On 2018-08-30 16:02, [ext] Pascal Bach wrote:
Thanks, applied to next, targeting master, thus rocko+. If you think
this should go into other branches as well, let us know.

Bach, Pascal

unread,
Aug 31, 2018, 8:28:41 AM8/31/18
to Kiszka, Jan, efibootg...@googlegroups.com
The patch is a result of me trying to get this layer working with current OE master (sumo+).

I have some more patches in the pipeline but they require a new release of efibootguard that includes the GCC 8 fixes.

> Jan

Jan Kiszka

unread,
Aug 31, 2018, 8:46:14 AM8/31/18
to Bach, Pascal (BT CPS R&D ZG FW CCP), efibootg...@googlegroups.com, Andreas Reichel
We originally had at least that recovery mode on the feature list for a
next release. That got delayed now, so it might be a good point for an
earlier release if it helps.

Andreas, what do you think?
Reply all
Reply to author
Forward
0 new messages