[PATCH] kernel-stub: Fix support for gnu-efi > 3.0.15

21 views
Skip to first unread message

Jan Kiszka

unread,
Jun 18, 2024, 10:49:54 AM6/18/24
to efibootguard-dev, Christian Storm, Christopher Obbard, Quirin Gylstorff
From: Jan Kiszka <jan.k...@siemens.com>

Adding the .rodata section was forgotten in c66041fc7c66, breaking the
kernel stub when being built against latest gnu-efi.

Signed-off-by: Jan Kiszka <jan.k...@siemens.com>
---
Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile.am b/Makefile.am
index 0bd2dec..2ea47ae 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -310,7 +310,7 @@ $(kernel_stub_solib): $(kernel_stub_objects)

$(kernel_stub_name): $(kernel_stub_solib)
$(AM_V_GEN) $(OBJCOPY) -j .text -j .sdata -j .data -j .dynamic \
- -j .dynsym -j .rel* $(objcopy_format) $< $@
+ -j .dynsym -j .rodata -j .rel* $(objcopy_format) $< $@

endif # BOOTLOADER

--
2.43.0

Christopher Obbard

unread,
Jun 18, 2024, 11:15:07 AM6/18/24
to Jan Kiszka, efibootguard-dev, Christian Storm, Quirin Gylstorff
Hi Jan,

On Tue, 2024-06-18 at 16:49 +0200, 'Jan Kiszka' via EFI Boot Guard wrote:
> From: Jan Kiszka <jan.k...@siemens.com>
>
> Adding the .rodata section was forgotten in c66041fc7c66, breaking the
> kernel stub when being built against latest gnu-efi.
>
> Signed-off-by: Jan Kiszka <jan.k...@siemens.com>

Thanks for the patch! It works for me when building with latest gnu-efi.

It will close the Debian bug #1072962 once it is imported. I will mark the bug
as fixed-upstream & link it to this thread.

Perhaps you wish to add the following to this commit?

Reported-by: Christopher Obbard <chris....@collabora.com>
Tested-by: Christopher Obbard <chris....@collabora.com>



Cheers!

Chris

Jan Kiszka

unread,
Jun 18, 2024, 11:18:51 AM6/18/24
to Christopher Obbard, efibootguard-dev, Christian Storm, Quirin Gylstorff
On 18.06.24 17:15, Christopher Obbard wrote:
> Hi Jan,
>
> On Tue, 2024-06-18 at 16:49 +0200, 'Jan Kiszka' via EFI Boot Guard wrote:
>> From: Jan Kiszka <jan.k...@siemens.com>
>>
>> Adding the .rodata section was forgotten in c66041fc7c66, breaking the
>> kernel stub when being built against latest gnu-efi.
>>
>> Signed-off-by: Jan Kiszka <jan.k...@siemens.com>
>
> Thanks for the patch! It works for me when building with latest gnu-efi.
>
> It will close the Debian bug #1072962 once it is imported. I will mark the bug
> as fixed-upstream & link it to this thread.
>
> Perhaps you wish to add the following to this commit?
>
> Reported-by: Christopher Obbard <chris....@collabora.com>
> Tested-by: Christopher Obbard <chris....@collabora.com>
>

Thanks, done!

Jan

--
Siemens AG, Technology
Linux Expert Center

Reply all
Reply to author
Forward
0 new messages