[meta-efibootguard][PATCH] package all debug symbol files in tools-dbg

8 views
Skip to first unread message

Raphael Freudiger

unread,
May 7, 2018, 6:55:40 AM5/7/18
to efibootg...@googlegroups.com, Raphael Freudiger
There is a QA warning that the debug symbol files are installed but not packaged,
if `PACKAGE_DEBUG_SPLIT_STYLE` is set to "debug-file-directory".
Depending on `PACKAGE_DEBUG_SPLIT_STYLE` the debug symbol files are installed in a .debug folder or in /usr/lib/debug.
The sources are in /usr/src/debug
With `PACKAGE_DEBUG_SPLIT_STYLE` set to ".debug" (debug), the debug symbol files are in the efibootguard-tools package
and installed with the binary.

Signed-off-by: Raphael Freudiger <raphael....@siemens.com>
---
recipes-bsp/efibootguard/efibootguard.bb | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/recipes-bsp/efibootguard/efibootguard.bb b/recipes-bsp/efibootguard/efibootguard.bb
index a1c504a..592f5da 100644
--- a/recipes-bsp/efibootguard/efibootguard.bb
+++ b/recipes-bsp/efibootguard/efibootguard.bb
@@ -24,10 +24,10 @@ inherit autotools deploy pkgconfig

COMPATIBLE_HOST = "(x86_64.*|i.86.*)-linux"

-PACKAGES = "${PN}-tools \
- ${PN}-tools-dbg \
+PACKAGES = "${PN}-tools-dbg \
${PN}-tools-staticdev \
${PN}-tools-dev \
+ ${PN}-tools \
${PN}-efi"

EXTRA_OECONF = "--with-gnuefi-sys-dir=${STAGING_DIR_HOST} \
@@ -35,7 +35,7 @@ EXTRA_OECONF = "--with-gnuefi-sys-dir=${STAGING_DIR_HOST} \
--with-gnuefi-lib-dir=${STAGING_LIBDIR}"

FILES_${PN}-tools = "${bindir}"
-FILES_${PN}-tools-dbg = "/usr/src/debug"
+FILES_${PN}-tools-dbg = "/usr/src/debug ${bindir}/.debug /usr/lib/debug"
FILES_${PN}-tools-staticdev = "${libdir}/lib*.a"
FILES_${PN}-tools-dev = "${includedir}/${BPN}"
FILES_${PN}-efi = "${libdir}/${BPN}"
--
2.11.0

Jan Kiszka

unread,
May 7, 2018, 7:18:35 AM5/7/18
to [ext] Raphael Freudiger, efibootg...@googlegroups.com, Andreas Reichel
Seems fine to me - Andreas?

Thanks!
Jan

--
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux

Andreas Reichel

unread,
May 7, 2018, 8:11:16 AM5/7/18
to [ext] Jan Kiszka, [ext] Raphael Freudiger, efibootg...@googlegroups.com, Andreas Reichel
Agreed
>
> Thanks!
> Jan
>
> --
> Siemens AG, Corporate Technology, CT RDA IOT SES-DE
> Corporate Competence Center Embedded Linux
>
> --
> You received this message because you are subscribed to the Google Groups "EFI Boot Guard" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to efibootguard-d...@googlegroups.com.
> To post to this group, send email to efibootg...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/efibootguard-dev/7aece4cd-e8da-ab91-8667-57b927b38f74%40siemens.com.
> For more options, visit https://groups.google.com/d/optout.

--
Andreas Reichel
Dipl.-Phys. (Univ.)
Software Consultant

Andreas...@tngtech.com, +49-174-3180074
TNG Technology Consulting GmbH, Betastr. 13a, 85774 Unterfoehring
Geschaeftsfuehrer: Henrik Klagges, Dr. Robert Dahlke, Gerhard Mueller
Sitz: Unterfoehring * Amtsgericht Muenchen * HRB 135082

Jan Kiszka

unread,
May 7, 2018, 10:05:41 AM5/7/18
to Andreas Reichel, [ext] Raphael Freudiger, efibootg...@googlegroups.com, Andreas Reichel
Applied to next.
Reply all
Reply to author
Forward
0 new messages