Getting EFI Boot Guard into Debian

44 views
Skip to first unread message

Jan Kiszka

unread,
Jul 24, 2022, 10:09:36 AM7/24/22
to efibootguard-dev, Bastian Germann, Quirin Gylstorff
Hi all,

it would be really great to have EBG as an official package in bookworm.
There is the initial work done by Bastian with contributions by Quirin
already [1], but EBG moved on since then and needs some more work to
support 0.12. Likely, we will need patches from current next as bookworm
is broken with that release. Some bits to account for structural changes
in the latest releases is in [2], possibly not in Debian shape yet.

Bastian, do you have the time to support this? What is needed from your
perspective, what should we contribute?

Thanks,
Jan

[1] https://salsa.debian.org/debian/efibootguard/
[2]
https://gitlab.com/cip-project/cip-core/isar-cip-core/-/tree/master/recipes-bsp/efibootguard

--
Siemens AG, Technology
Competence Center Embedded Linux

Bastian Germann

unread,
Jul 25, 2022, 6:04:29 PM7/25/22
to Jan Kiszka, efibootguard-dev, Quirin Gylstorff, 100...@bugs.debian.org
Am 24.07.22 um 16:09 schrieb Jan Kiszka:
> Hi all,
>
> it would be really great to have EBG as an official package in bookworm.
> There is the initial work done by Bastian with contributions by Quirin
> already [1], but EBG moved on since then and needs some more work to
> support 0.12. Likely, we will need patches from current next as bookworm
> is broken with that release. Some bits to account for structural changes
> in the latest releases is in [2], possibly not in Debian shape yet.
>
> Bastian, do you have the time to support this? What is needed from your
> perspective, what should we contribute?

I have updated the package to build v0.12 but run into:
./configure: line 14997: syntax error near unexpected token `-mgeneral-regs-only,'
./configure: line 14997: `AX_CHECK_COMPILE_FLAG(-mgeneral-regs-only,'

Full log at https://salsa.debian.org/debian/efibootguard/-/jobs/3036697

The suggested "next" changes do not fix this.

So if you could provide a patch for this I can hand in the package.
I would prefer not to be responsible for it and can hand over maintainership to
somebody who actually uses the software. I can grant git access for that person with
a salsa (Gitlab) username provided.

Whoever wants to be the package maintainer please make #1001214 an ITP (retitle and own the bug).

Gylstorff Quirin

unread,
Jul 26, 2022, 9:41:53 AM7/26/22
to Bastian Germann, Jan Kiszka, efibootguard-dev, 100...@bugs.debian.org


On 7/26/22 00:04, Bastian Germann wrote:
> Am 24.07.22 um 16:09 schrieb Jan Kiszka:
>> Hi all,
>>
>> it would be really great to have EBG as an official package in bookworm.
>> There is the initial work done by Bastian with contributions by Quirin
>> already [1], but EBG moved on since then and needs some more work to
>> support 0.12. Likely, we will need patches from current next as bookworm
>> is broken with that release. Some bits to account for structural changes
>> in the latest releases is in [2], possibly not in Debian shape yet.
>>
>> Bastian, do you have the time to support this? What is needed from your
>> perspective, what should we contribute?
>
> I have updated the package to build v0.12 but run into:
> ./configure: line 14997: syntax error near unexpected token
> `-mgeneral-regs-only,'
> ./configure: line 14997: `AX_CHECK_COMPILE_FLAG(-mgeneral-regs-only,'
>
> Full log at https://salsa.debian.org/debian/efibootguard/-/jobs/3036697
>
> The suggested "next" changes do not fix this.
>

I create an MR on salsa with the necessary fixes.

Quirin

Bastian Germann

unread,
Jul 26, 2022, 11:17:22 AM7/26/22
to Gylstorff Quirin, Jan Kiszka, efibootguard-dev, 100...@bugs.debian.org
>> Am 24.07.22 um 16:09 schrieb Jan Kiszka:
>>> it would be really great to have EBG as an official package in bookworm.
>>> There is the initial work done by Bastian with contributions by Quirin
>>> already [1], but EBG moved on since then and needs some more work to
>>> support 0.12. Likely, we will need patches from current next as bookworm
>>> is broken with that release. Some bits to account for structural changes
>>> in the latest releases is in [2], possibly not in Debian shape yet.

"broken" is a bit of a stretch. Instead of taking the patches from next I came up with
https://salsa.debian.org/debian/efibootguard/-/commit/6f62ed00158dbdeb2e4559a6c052ac8db41b53e6

It would help downstream packages to apply CFLAGS and LDFLAGS as you can also see with Debian's blhc checks at
https://salsa.debian.org/debian/efibootguard/-/jobs/3039310

Bastian Germann

unread,
Jul 26, 2022, 11:32:17 AM7/26/22
to Jan Kiszka, efibootguard-dev, Quirin Gylstorff, 100...@bugs.debian.org
Am 26.07.22 um 00:04 schrieb Bastian Germann:
> I would prefer not to be responsible for it and can hand over maintainership to
> somebody who actually uses the software. I can grant git access for that person with
> a salsa (Gitlab) username provided.
>
> Whoever wants to be the package maintainer please make #1001214 an ITP (retitle and own the bug).

Quirin, do you want to step up as maintainer? I would still be sponsoring your package uploads but do not want to take
responsibility for the package because I have never used it.

To make this your ITP send an answer including the bug address with the first two lines:

Control: retitle -1 ITP: efibootguard -- UEFI-based bootloader
Control: owner -1 Quirin Gylstorff <quirin.g...@siemens.com>

Thanks,
Bastian

Gylstorff Quirin

unread,
Aug 1, 2022, 10:34:32 AM8/1/22
to Bastian Germann, Jan Kiszka, efibootguard-dev, 100...@bugs.debian.org
Control: retitle -1 ITP: efibootguard -- UEFI-based bootloader
Control: owner -1 Quirin Gylstorff <quirin.g...@siemens.com>




After an internal discuss I would step up as the Maintainer for
efibootguard.

Thanks,
Quirin

Bastian Germann

unread,
Aug 13, 2022, 10:21:48 PM8/13/22
to Gylstorff Quirin, Jan Kiszka, efibootguard-dev, 100...@bugs.debian.org
Am 01.08.22 um 16:34 schrieb Gylstorff Quirin:
> After an internal discuss I would step up as the Maintainer for efibootguard.

Thanks. I have invited you to the git repo. Please change 0.12-1's changelog signature line to your
Name and email and the current date so I can sponsor the package for you.
Reply all
Reply to author
Forward
0 new messages