[PATCH 3/7] watchdog: ipmi_wdt: Avoid pointless check at loop entry

6 views
Skip to first unread message

Jan Kiszka

unread,
Oct 19, 2023, 1:36:32 PM10/19/23
to efibootg...@googlegroups.com
From: Jan Kiszka <jan.k...@siemens.com>

Moving the test to the end avoids the need to initialize timerstatus.
And it also no longer confuses cppcheck 2.10.

Signed-off-by: Jan Kiszka <jan.k...@siemens.com>
---
drivers/watchdog/ipmi_wdt.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/watchdog/ipmi_wdt.c b/drivers/watchdog/ipmi_wdt.c
index f67100d..55d9623 100644
--- a/drivers/watchdog/ipmi_wdt.c
+++ b/drivers/watchdog/ipmi_wdt.c
@@ -132,7 +132,7 @@ handle_ipmi_error(UINT16 io_base)
static EFI_STATUS
send_ipmi_cmd(UINT16 io_base, UINT8 cmd, UINT8 *data, UINTN datalen)
{
- EFI_STATUS timerstatus = EFI_NOT_READY;
+ EFI_STATUS timerstatus;
EFI_STATUS status;

/*
@@ -141,13 +141,13 @@ send_ipmi_cmd(UINT16 io_base, UINT8 cmd, UINT8 *data, UINTN datalen)
*/
BS->SetTimer(cmdtimer, TimerRelative, 50000000);

- while (timerstatus == EFI_NOT_READY) {
+ do {
status = _send_ipmi_cmd(io_base, cmd, data, datalen);
if (status == EFI_SUCCESS)
return status;
handle_ipmi_error(io_base);
timerstatus = BS->CheckEvent(cmdtimer);
- }
+ } while (timerstatus == EFI_NOT_READY);

return status;
}
--
2.35.3

JEMS EBERHARD HORBEL

unread,
Dec 9, 2023, 1:55:55 PM12/9/23
to EFI Boot Guard
DIRECT SENDER IS HERE LETS DEAL.

JENS EBERHARD



MT103/202 DIRECT WIRE TRANSFER
PAYPAL TRANSFER
CASHAPP TRANSFER
ZELLE TRANSFER
TRANSFER WISE
WESTERN UNION TRANSFER
BITCOIN FLASHING 
BANK ACCOUNT LOADING/FLASHING
IBAN TO IBAN TRANSFER
MONEYGRAM TRANSFER
SLBC PROVIDER
CREDIT CARD TOP UP
SEPA TRANSFER
WIRE TRANSFER
GLOBALPAY INC US

Thanks.


NOTE; ONLY SERIOUS / RELIABLE RECEIVERS CAN CONTACT.

DM ME ON WHATSAPP FOR A SERIOUS DEAL.

+447405129573
Reply all
Reply to author
Forward
0 new messages