[PATCH] drivers/atom-quark: Fix cppcheck error

2 views
Skip to first unread message

Jan Kiszka

unread,
Dec 2, 2020, 7:34:47 AM12/2/20
to efibootguard-dev
From: Jan Kiszka <jan.k...@siemens.com>

"Shifting signed 32-bit value by 31 bits is undefined behaviour"

Signed-off-by: Jan Kiszka <jan.k...@siemens.com>
---
drivers/watchdog/atom-quark.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/watchdog/atom-quark.c b/drivers/watchdog/atom-quark.c
index b17ff27..e3a5495 100644
--- a/drivers/watchdog/atom-quark.c
+++ b/drivers/watchdog/atom-quark.c
@@ -21,7 +21,7 @@
#define PCI_DEVICE_ID_INTEL_QUARK_X1000 0x095e

#define WDTBA_REG 0x84
-# define WDTBA_ENABLED (1 << 31)
+# define WDTBA_ENABLED (1U << 31)
# define WDTBA_ADDRMASK 0xffc0

#define TIMER1_REG 0x00
--
2.26.2
Reply all
Reply to author
Forward
0 new messages