A lice-sized code review (edward localrev 86)

[edy...@gmail.com]

Hello davidterei,

I'd like you to do a code review. Please review the following patch:

----------------------------------------------------------------------
r86: edward | 2007-09-16 21:46:09 +0800

Added javadoc support and fixed the bug when copying resource files.

Usage:

Copy build.properties.sample to build.properties and modify the file
according to your need.

----------------------------------------------------------------------

=== build.xml
==================================================================
--- build.xml (revision 85)
+++ build.xml (revision 86)
@@ -7,7 +7,7 @@
<target name="init">
<copy includeemptydirs="false" todir="org.eeedit.vimclient_${VERSION}">
<fileset dir="eeedit"
- excludes="**/*.launch, **/*.java, **/*.properties"/>
+ excludes="**/*.launch, **/*.java, **/build.properties"/>
</copy>
</target>
<target name="clean">
@@ -16,14 +16,22 @@
</delete>
</target>
<target name="cleanall">
- <delete dir="org.eeedit.vimclient_${VERSION}" />
+ <delete dir="org.eeedit.vimclient_${VERSION}"/>
</target>
<target depends="build-subprojects,build-project" name="build"/>
<target name="build-subprojects"/>
<target depends="init" name="build-project">
<javac destdir="org.eeedit.vimclient_${VERSION}">
- <src path="eeedit/src" />
- <classpath refid="eeedit.classpath" />
+ <src path="eeedit/src"/>
+ <classpath refid="eeedit.classpath"/>
</javac>
</target>
+ <target name="doc">
+ <delete dir="doc"/>
+ <mkdir dir="doc"/>
+ <javadoc destdir="doc" encoding="UTF-8" docencoding="UTF-8" locale="en_US">
+ <fileset dir="eeedit/src" includes="**/*.java"/>
+ <classpath refid="eeedit.classpath"/>
+ </javadoc>
+ </target>
</project>

This is a semiautomated message from "svkmail". Complaints or suggestions?
Mail edy...@gmail.com.

[David Terei]

Looks good.

Best regards,
David