import?

[Yuri]

https://github.com/eea/eea.facetednavigation/blob/master/eea/facetednavigation/profiles/default/cssregistry.xml

<?xml version="1.0"?>
<object name="portal_css" meta_type="Stylesheets Registry">
<stylesheet id="@@faceted_view.css" remove="True" />
<stylesheet id="@@faceted_edit.css" remove="True" />
<stylesheet title="Faceted View CSS" cacheable="True" compression="none"
cookable="True" enabled="on" expression=""
id="faceted_view.css" media="all" rel="stylesheet" rendering="import"/>
<stylesheet title="Faceted Edit CSS" cacheable="True" compression="none"
cookable="True" enabled="on"
expression="python:'configure_faceted.html' in request.URL0"
id="faceted_edit.css" media="all" rel="stylesheet" rendering="import"/>
</object>


Why import instead of link and compressione none? It dates from 2009, is
still valid now? import should be worst for performaces, plus Plone
portal_css merging interrupts.

http://lmgtfy.com/?q=css+import+performance

[Alexandru Ghica]

Hi Yuri,

I can confirm that it's just old code/settings which were not updated.
It should be link instead of import. Can you please correct and commit
that on GitHub?

Best regards,
Alec

--
Alexandru Ghica
Eau de Web (http://www.eaudeweb.ro)
Maior Gheorghe Șonțu 8, ap 3 - 011448 Bucharest
Tel/fax: +40 21 222 1522, Mobile: +40 722 688 168
Jabber: al...@jabber.eaudeweb.ro, Skype: alecghica

[Yuri]

Il 26/06/2014 12:11, Alexandru Ghica ha scritto:
> Hi Yuri,
>
> I can confirm that it's just old code/settings which were not updated.
> It should be link instead of import. Can you please correct and commit
> that on GitHub?

what about compression None? it could be also a problem for merging.
Maybe someone can test if changing this values can cause some problemi
with other javascript? Sometimes it happens that some javascript cannot
be compressed or merged for some obscure (to me) reason.

[Alexandru Ghica]

Hi Yuri,

The compression is fine to be active. If creates problem to merging it
should be locally deactivated. For best performance compression should
be active.

Best regards,
Alec

[Yuri]

Ok, please do the change if it is ok :-)

[Alexandru Ghica]

Hi Yuri,

Fixed, see
https://github.com/collective/eea.facetednavigation/commit/283c61b2ae60c28ef9de947045ca15b5556833b8

Best regards,
Alec

[Yuri]

what about compression? it is none actually:

<stylesheet title="Faceted View CSS" cacheable="True" compression="none"

<stylesheet title="Faceted Edit CSS" cacheable="True" compression="none"

Thanks for this fix :-)

[Alexandru Ghica]

Hi Yuri,

I'll  have to take a look first and properlly tested it. You can however set compression to safe on your portal, it should behave fine :)

Best regards,
Alec

[Yuri]

What about this:

<javascript cacheable="True" compression="none" cookable="True"
enabled="True"
expression="python: request.get('jsdisable','') != 'jquery'"
id="faceted_view.js" inline="False"/>

I don't understand where "jsdisable" came from, is still valid this
condition? The js is loaded even if we're not in a facetednavigation page.

[Alin Voinea]

Same issue, old and not used anymore. This should be enough:

<javascript id="faceted_view.js" />
<javascript id="faceted_edit.js"
expression="python:'configure_faceted.html' in request.URL0" />

--
Alin Voinea

Avertisment: Acest email poate conține ironii, jocuri de cuvinte, metafore sau epitete. Se recomanda citirea cu atenție a acestuia de mai multe ori dacă este cazul. În cazul în care după 3 recitiri consecutive încă mai aveți nelămuriri luați o pauza de 5 minute, beți o cafea, fumați o țigară (după caz). Dacă simptomele persista adresați-va de urgenta unui specialist (prieten(ă), soț(ie), amant(ă), etc.)

[Alin Voinea]

Fixed: https://github.com/collective/eea.facetednavigation/commit/5db5a2fd6d87dc4acc32c94c48663e8521c64710

[Yuri]

great, yet another javacript merged :-)

What was the old "issue"? Is there a release in particular?

> --
> You received this message because you are subscribed to the Google
> Groups "EEA Faceted Navigation" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to eea-facetednavig...@googlegroups.com
> <mailto:eea-facetednavig...@googlegroups.com>.
> To post to this group, send email to
> eea-facete...@googlegroups.com
> <mailto:eea-facete...@googlegroups.com>.
> Visit this group at http://groups.google.com/group/eea-facetednavigation.
> For more options, visit https://groups.google.com/d/optout.

[Alin Voinea]

:)

Well these JS and CSS XML were there since Plone 2.5.

The jsdisable marker was an EEA specific one and it shouldn't be there from the beginning ;)