Enrollment/Unenrollment emails are not in the correct language

78 views
Skip to first unread message

Régis Behmo

unread,
Nov 26, 2014, 4:59:40 AM11/26/14
to edx-...@googlegroups.com
Hi there,

In the instructor dashboard, whenever a list of students is manually enrolled, unenrolled or assigned a beta role, an email is sent to each student to inform him of the changer. This email is currently written in the instructor's language, while it should be written in the student's language.

This issue is due to the fact that the language is at no point modified in the enroll_email, unenroll_email and send_beta_role_email functions from lms/djangoapps/instructor/enrollment.py.

I can quickly produce a first draft for a pull request to fix this. Is there a process that I should follow? Should someone open an issue? Unfortunately, I do not have the permission to create issues in https://openedx.atlassian.net/browse/OSPR/

--
Régis, software developer @ France Université Numérique

Molly de Blanc

unread,
Dec 2, 2014, 4:48:41 PM12/2/14
to edx-...@googlegroups.com
We use http://readthedocs.org for a lot of the documentation relating to the contribution process. For code contributions, pull requests, and becoming a contributor, you should read: http://edx.readthedocs.org/projects/edx-developer-guide/en/latest/process/index.html. If you have any questions after that, write back to the e-mail list or try the IRC channel #edx-code on irc.freenode.net.

Cheers,
Molly
--
---
Molly de Blanc
Community Coordinator
Open edX
141 Portland St, Cambridge, MA 02139

David Baumgold

unread,
Dec 2, 2014, 4:52:28 PM12/2/14
to edx-...@googlegroups.com
Régis, you say you don’t have permission to create issues in openedx.atlassian.net. Have you created an account for yourself? Anyone can create issues on our JIRA, but you need to register for an account and log in first, so we know who did what. To create an account, click on the “Log in” link in the upper right corner of the page, and then click on the “Create an account” link at the bottom of the login form. Once you’ve logged in, you should have permission to create issues.

DB

Régis Behmo

unread,
Dec 3, 2014, 3:47:38 AM12/3/14
to edx-...@googlegroups.com
Molly, David, thanks for your answer!
For some reason, I could not manually create a Jira issue right after I created an account on Jira, but I am now able to.

I've since opened a pull request that fixes this issue: https://github.com/edx/edx-platform/pull/6082
It currently has the "product review" status. Tests pass. Please feel free to pitch in on this PR!
Reply all
Reply to author
Forward
0 new messages