Comprehensive theme: Is it ready for production?
89 views
Skip to first unread message
Filippo Panessa
Jul 27, 2016, 5:27:45 AM7/27/16
to edx-...@googlegroups.com
Hello,
I made some tests for comprehensive theme but it seems not fully
implemented yet.
Starting from
/edx/app/edxapp/edx-platform/lms/static/sass/partials/base/_variables.scss
I developed my custom _variables.scss file (attached). It works after
running edx-update-asset-lms script, but it doesn't cover all CSS
classes and templates.
For instance, button-primary class is not overridden in login and
register pages. Instead buttons in the header change their color
according to $action-primary.
Templates have some issues too. I'm able to override header.html and
footer.html, but it simply doesn't work for stuff like login*.html and
register*.html.
I had the some issue with dogwood, eucalyptus and master branch.
I made some tests for comprehensive theme but it seems not fully
implemented yet.
Starting from
/edx/app/edxapp/edx-platform/lms/static/sass/partials/base/_variables.scss
I developed my custom _variables.scss file (attached). It works after
running edx-update-asset-lms script, but it doesn't cover all CSS
classes and templates.
For instance, button-primary class is not overridden in login and
register pages. Instead buttons in the header change their color
according to $action-primary.
Templates have some issues too. I'm able to override header.html and
footer.html, but it simply doesn't work for stuff like login*.html and
register*.html.
I had the some issue with dogwood, eucalyptus and master branch.
pdesj...@edx.org
Jul 28, 2016, 10:38:07 AM7/28/16
to General Open edX discussion
Hi, Filippo.
The implementation of theming has recently been improved significantly. Because, you can only override header.html and footer.html, I think you are using the older method of theming.
We are currently writing documentation for the new theming functionality and I believe it will be included in the upcoming Open edX named release.
Just to confirm, which version of Open edX are you using? Are you able to update to a later version (such as the upcoming named release)?
Peter
Filippo Panessa
Jul 28, 2016, 12:10:54 PM7/28/16
to edx-...@googlegroups.com
On 28 July 2016 at 16:38, <pdesj...@edx.org> wrote:
> Hi, Filippo.
>
> The implementation of theming has recently been improved significantly.
> Because, you can only override header.html and footer.html, I think you are
> using the older method of theming.
So, what should be the new way? Is it not enough having login.html
> Hi, Filippo.
>
> The implementation of theming has recently been improved significantly.
> Because, you can only override header.html and footer.html, I think you are
> using the older method of theming.
file into templates directory?
And what about action-primary for scss?
> We are currently writing documentation for the new theming functionality and
> I believe it will be included in the upcoming Open edX named release.
> Just to confirm, which version of Open edX are you using? Are you able to
> update to a later version (such as the upcoming named release)?
make some test if you wish.
Reply all
Reply to author
Forward
0 new messages