Code changes

[Oskar Laubsch]

Hello,

I've just submitted a pull request to the BETRA fork on GitHub:
👉 https://github.com/szlauf/eden-asp

The changes include:

• Making note_type_id optional and editable in dvr_note

• Renaming labels for:

  • note_type_id → "Note Type (optional)"

  • dvr_note_type.name → "Name of note"

  • dvr_task.due_date → "Report Date"

  • (attempted) dvr_case_activity.need_details → "Comment"

The custom resource methods are declared in config.py as:

settings.customise_dvr_note_resource = dvr_note_resource
settings.customise_dvr_case_activity_resource = dvr_case_activity_resource
settings.customise_dvr_task_resource = dvr_task_resource

Everything works fine except changing the label for need_details. I tried several approaches, but none of them had any effect. For now, I've just hidden the field (readable = False), but I’d appreciate any pointers on how to correctly rename its label for future use.

[Dominic König]

Hi Oskar--

thank you - I added a full code review on your PR :) hope this helps. We can
discuss your changes further on GitHub.

It looks like you have the general direction right with how to work with the
template - which is incredible given how little introduction you've had so
far. Let me know if there are any general concepts you want explained more in-
depth, so we can arrange another call to look into that.

Best wishes,
Dominic

tisdag 1 april 2025 15:00:53 CEST skrev 'Oskar Laubsch' via Eden ASP:
> Hello,
>
> I've just submitted a pull request to the BETRA fork on GitHub:
> 👉 https://github.com/szlauf/eden-asp
>
> The changes include:
>

> -

>
> Making note_type_id optional and editable in dvr_note

> -
>
> Renaming labels for:
> -
>
> note_type_id → "Note Type (optional)"
> -
>
> dvr_note_type.name → "Name of note"
> -
>
> dvr_task.due_date → "Report Date"
> -

>
> (attempted) dvr_case_activity.need_details → "Comment"
>
> The custom resource methods are declared in config.py as:
>
> settings.customise_dvr_note_resource = dvr_note_resource
> settings.customise_dvr_case_activity_resource = dvr_case_activity_resource
> settings.customise_dvr_task_resource = dvr_task_resource
>
> Everything works fine except changing the label for need_details. I tried
> several approaches, but none of them had any effect. For now, I've just
> hidden the field (readable = False), but I’d appreciate any pointers on how
> to correctly rename its label for future use.
>
>

> --
> You received this message because you are subscribed to the Google Groups
> "Eden ASP" group. To unsubscribe from this group and stop receiving emails
> from it, send an email to eden-asp+u...@googlegroups.com. To view
> this discussion visit
> https://groups.google.com/d/msgid/eden-asp/ec907bce-70b7-42fb-8b5d-0f8d62e8
> 9c70n%40googlegroups.com.

[Dominic König]

P.S. Oskar -- could you also please fill in this CLA form:

https://docs.google.com/forms/d/1RMUAZzcMO_ATeQriGt90ZNJIW3DJJPcNfYmflifBlqg/
edit?ts=67d381e7

...in case you haven't done so already?

Dominic