Java 9 Modules / Postgis Net

27 views
Skip to first unread message

Ryszard Trojnacki

unread,
Jul 17, 2024, 10:39:56 AM7/17/24
to Ebean ORM
Hi Rob,

I wanted to move to Java 9 Modules and there where few problems with this, but the main problem was with ebean-postgis-types module with dependency to net.postgis.postgis-jdbc. The old versions are not compatible with java modules.

I have checked that there was some work done in branch https://github.com/ebean-orm/ebean/tree/feature/postgis-net months ago, but not finished (?).

Moving forward - I has able to update net.postgis.postgis-jdbc to 2023.1.0 and it seems to work. It passes all the tests during build (mvn clean install) and my application compiles and starts (needs more tests - I will know tomorrow).


I wanted to make a pull request but I have two dilemmas:
1. net.postgis.postgis-jdbc is not compatible with old version, because of the package name change. Should I copy this (ebean-postgis-types) to new module ebean-net-postgis-types?
2. There are two versions of ebean 14 and 15. I have only changed 14 (master). Should I prepare a patch for 15?

-- 
Greetings,
Ryszard Trojnacki




Rob Bygrave

unread,
Jul 17, 2024, 10:42:46 PM7/17/24
to eb...@googlegroups.com
> 2. There are two versions of ebean 14 and 15. I have only changed 14 (master). Should I prepare a patch for 15?

We only need a PR for master (14).

When we perform a release we merge changes from master into the 15 branch. In this way 15 is kept in sync with master(14) in terms of features and bug fixes etc.  So no we don't need a patch for 15.


> 1. net.postgis.postgis-jdbc is not compatible with old version, because of the package name change. Should I copy this (ebean-postgis-types) to new module ebean-net-postgis-types?

Yes, I think this is a good approach (I think this is better than changing the existing which will be a breaking change). As I see it, it is tempting to remove the GeoLatte types from the new module as well. Do you use GeoLatte? 


Cheers, Rob.

--

---
You received this message because you are subscribed to the Google Groups "Ebean ORM" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ebean+un...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/ebean/b4d877ca-b761-46c2-88b6-9d327fe9debfn%40googlegroups.com.

Ryszard Trojnacki

unread,
Jul 18, 2024, 5:00:04 AM7/18/24
to Ebean ORM
I have create a new branch for this: https://github.com/Ryszard-Trojnacki/ebean/tree/feature/net-postgis-types

1. I had to add 2 modules:

2. I had to make few changes to module-info.java for ebean-core module.

3. There were few missing entries for Java modules:

4. I have removed GeoLatte from new net-postgist-types. I'm working with ebean postgis for 2 years and I didn't need to use them.

I have tested this new net-postgist-types module with my project with use of Java modules and so far everything works.

If everything is correct I will create PR.

BTW. In postgis there is geometry (PGgeometry) and geography (PGgeography) https://postgis.net/documentation/faq/geometry-or-geography/. Ebean postgis only uses geometry.  I'm wondering If there should be support for geography? I never used geography and I aware of this mode since today.

-- 
Greetings,
Ryszard Trojnacki

Rob Bygrave

unread,
Jul 18, 2024, 5:56:55 AM7/18/24
to eb...@googlegroups.com
Good work, that all looks good. 


> geography

My thinking is that at this stage no one has asked for it and I feel it's actually unlikely. So I'm happy with the status quo.


Cheers, Rob.


To view this discussion on the web visit https://groups.google.com/d/msgid/ebean/c9985079-e6ff-4f98-b697-464b39c5d518n%40googlegroups.com.
Reply all
Reply to author
Forward
0 new messages