NULL pointer dereference with latest git versin 3.17 kernel

[tosiara]

After unplugging the device:


[  378.344503] BUG: unable to handle kernel NULL pointer dereference at           (null)
[  378.348823] IP: [<ffffffffa0b1d74f>] smi2021_set_mode.isra.4+0x4f/0xa0 [smi2021]
[  378.350955] PGD 146274067 PUD 147e80067 PMD 0
[  378.353097] Oops: 0000 [#1] PREEMPT SMP
[  378.355680] Modules linked in: md4 md5 nls_utf8 cifs saa7115 smi2021 rfcomm nfsv3 nfs_acl rpcsec_gss_krb5 auth_rpcgss oid_registry nfsv4 ctr ccm xt_pkttype nfs ppdev parport_pc parport fuse fscache lockd vmw_vsock_vmci_transport vsock vmw_vmci sunrpc af_packet ip6t_REJECT xt_tcpudp nf_conntrack_ipv6 nf_defrag_ipv6 ip6table_raw ipt_REJECT iptable_raw xt_CT iptable_filter ip6table_mangle nf_conntrack_netbios_ns nf_conntrack_broadcast nf_conntrack_ipv4 nf_defrag_ipv4 ip_tables xt_conntrack nf_conntrack bnep ip6table_filter ip6_tables x_tables ecb x86_pkg_temp_thermal intel_powerclamp coretemp kvm_intel kvm arc4 ath9k mac80211 ath3k snd_hda_codec_realtek snd_hda_codec_hdmi btusb snd_hda_codec_generic crc32_pclmul bluetooth ath9k_common snd_hda_intel ath9k_hw crc32c_intel snd_hda_controller ghash_clmulni_intel
[  378.366013]  ath snd_hda_codec aesni_intel cfg80211 snd_hwdep ablk_helper snd_pcm cryptd snd_seq uvcvideo iTCO_wdt iTCO_vendor_support snd_timer snd_seq_device lpc_ich videobuf2_core v4l2_common r8169 lrw snd sparse_keymap videodev mfd_core mii rfkill gf128mul mei_me shpchp soundcore mei videobuf2_vmalloc videobuf2_memops sr_mod cdrom glue_helper i2c_i801 aes_x86_64 pcspkr joydev serio_raw button wmi toshiba_bluetooth battery video ac sg dm_mod autofs4 btrfs raid6_pq xor radeon ttm drm_kms_helper drm xhci_hcd i2c_algo_bit thermal processor thermal_sys scsi_dh_rdac scsi_dh_emc scsi_dh_alua scsi_dh_hp_sw scsi_dh
[  378.380560] CPU: 0 PID: 1959 Comm: vlc Not tainted 3.17.0-rc6-21-desktop+ #1
[  378.383590] Hardware name: TOSHIBA SATELLITE L850/Type2 - Board Product Name1, BIOS 6.80 10/01/2013
[  378.387255] task: ffff8800a9c844d0 ti: ffff8800a8410000 task.ti: ffff8800a8410000
[  378.390382] RIP: 0010:[<ffffffffa0b1d74f>]  [<ffffffffa0b1d74f>] smi2021_set_mode.isra.4+0x4f/0xa0 [smi2021]
[  378.393562] RSP: 0018:ffff8800a8413d70  EFLAGS: 00010246
[  378.397264] RAX: ffff880145a5dc40 RBX: ffff880145a5dc40 RCX: 0000000000000040
[  378.400443] RDX: 0000000000000001 RSI: 0000000000000000 RDI: 0000000000000000
[  378.403626] RBP: ffff8800a8413da0 R08: 0000000000000001 R09: 0000000000000000
[  378.406786] R10: ffff880147e70000 R11: ffff880147da8000 R12: ffff880147d72008
[  378.409930] R13: 0000000000000003 R14: ffff880147d72e18 R15: ffff880148a7b960
[  378.413060] FS:  00007fab6c147700(0000) GS:ffff88014ec00000(0000) knlGS:0000000000000000
[  378.416377] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[  378.419548] CR2: 0000000000000000 CR3: 0000000146614000 CR4: 00000000000407f0
[  378.422754] Stack:
[  378.425935]  ffff880148a7b960 ffff8800a8413d90 ffffffff814771ef 0000000000000080
[  378.429199]  ffff8800a4abc600 ffff880147d72000 ffff8800a8413dc8 ffffffffa0b1e090
[  378.432463]  ffff880147d72bb0 ffff880147d72000 ffff880147d72e20 ffff8800a8413e00
[  378.435730] Call Trace:
[  378.439248]  [<ffffffff814771ef>] ? urb_destroy+0x1f/0x30
[  378.442497]  [<ffffffffa0b1e090>] smi2021_stop+0x80/0x90 [smi2021]
[  378.445748]  [<ffffffffa0b1e8a9>] stop_streaming+0x29/0xe0 [smi2021]
[  378.449244]  [<ffffffffa04a9626>] __vb2_queue_cancel+0x26/0x180 [videobuf2_core]
[  378.452535]  [<ffffffffa04acda5>] vb2_queue_release+0x15/0x30 [videobuf2_core]
[  378.455814]  [<ffffffffa04ace21>] _vb2_fop_release+0x61/0xa0 [videobuf2_core]
[  378.459041]  [<ffffffffa04ace85>] vb2_fop_release+0x25/0x50 [videobuf2_core]
[  378.462344]  [<ffffffffa045940f>] v4l2_release+0x2f/0x70 [videodev]
[  378.465648]  [<ffffffff811b1ab6>] __fput+0xc6/0x1d0
[  378.468953]  [<ffffffff811b1bf9>] ____fput+0x9/0x10
[  378.472229]  [<ffffffff81077067>] task_work_run+0x97/0xd0
[  378.475495]  [<ffffffff81002f21>] do_notify_resume+0x61/0xa0
[  378.478761]  [<ffffffff8162b52a>] int_signal+0x12/0x17
[  378.482103] Code: e8 97 6f 67 e0 48 85 c0 48 89 c3 74 5f c6 00 01 44 88 68 01 45 31 c9 49 8b 3c 24 41 b8 01 00 00 00 b9 40 00 00 00 ba 01 00 00 00 <8b> 37 c7 44 24 10 e8 03 00 00 c7 44 24 08 02 00 00 00 48 89 04
[  378.489253] RIP  [<ffffffffa0b1d74f>] smi2021_set_mode.isra.4+0x4f/0xa0 [smi2021]
[  378.492716]  RSP <ffff8800a8413d70>
[  378.496056] CR2: 0000000000000000
[  378.512267] ---[ end trace f1184745d61b846f ]---
[  380.185744] usb 3-2: USB disconnect, device number 11

[tosiara]

Submitted also to github: https://github.com/jonjonarnearne/smi2021/issues/1

[Jon Arne Jørgensen]

Thanks, I'll look into that.

Did it work otherwise?

> --
> You received this message because you are subscribed to the Google Groups
> "easycap-somagic-linux" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to easycap-somagic-...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.



--
Jonarne
http://jonarne.no

[Jon Arne Jørgensen]

Thanks, I'll look into that.

Did it work otherwise?

[tosiara]

Yeah, all other works fine

By the way, did you implement incomplete frames drop in this version?

> email to easycap-somagic-linux+unsub...@googlegroups.com.

[Jon Arne Jørgensen]

Actually, it's been so long since I wrote that algorithm. I don't remember any more.
It's really easy to add it back in if it isn't there and somebody needs it.

To unsubscribe from this group and stop receiving emails from it, send an email to easycap-somagic-...@googlegroups.com.

[tosiara]

I request that feature! :)
Without dropping bad incomplete frames there will be an issue with motion detection aka "crawling frames": https://groups.google.com/d/msg/easycap-somagic-linux/Ay_YhrS8VfA/pE_XGtITWooJ

> email to easycap-somagic-linux+unsubscri...@googlegroups.com.

> For more options, visit https://groups.google.com/d/optout.



--
Jonarne
http://jonarne.no