Tool table doesn't work

[richk...@gmail.com]

Hi

The other week I created a DXF for dxf2gcode using the tool table (Tn directive) rather than directly specifying the tool diameter as I usually do.  To my surprise I couldn't get it work.  After fiddling with the source code for a while I realised that there are two issues:

1. the tool number is read from the layer description as a float.  As the tool number is converted to string before comparison with the tool table it end up with a trailing decimal point (e.g. 1.0 rather than 1) for the comparison - which can therefore never match.
2. If the tool does match the rest of the parameters - diameter, feed etc. - are not updated (unless the tool table itself is subsequently changed) and cannot be changed from the user interface since the tool number is defined.

I have created a patch to address both issues, which is attached.  There are some rough edges, e.g. the default tool is a constant declared in the source code - that is now used in more than one file, so should really be pulled out into one of the constants files.

I hope this is useful and can be included in the source repository

thanks

Richard

[Christian Kohlöffel]

HI Richard,

 

i will implement the Patches into the source Code repository and i am sure that every improvement will help the others users of dxf2gcode. I am not using the option as you described below, which means i am not able to test or comment the changes. Thank you very much for your time digging into the code, I know that can really take a while.

 

Best regards

Christian

--
--
You received this message because you subscribed to the Google
Groups-group "dxf2gcode-dev".
To post a message, send mail to dxf2gc...@googlegroups.com
To unsubscribe, send mail to dxf2gcode-de...@googlegroups.com
See http://groups.google.de/group/dxf2gcode-dev?hl=en for more options
and the dxf2gcode project page at http://code.google.com/p/dxf2gcode/
---
You received this message because you are subscribed to the Google Groups "dxf2gcode-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to dxf2gcode-de...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.