polyline fix

[Sebastian Kuzminsky]

Hello Christian, I got a bug report against version 20170925, related to
the LWPolyLine fix you made recently (2bab0a20):

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=894206

The patch proposed there fixes both the LWPolyLine bug you fixed, and (i
think) the same bug in regular PolyLines. I think there's no need for
that LWPolyLine fix since your commit implements the same check, but
probably the PolyLine part of the patch should go into develop?

Unfortunately we don't have a DXF that demonstrates the PolyLine bug.
The DXF that Sebastian Reichel attached to that debian bug imports
correctly in both develop and in 20170925 with the patch from the debian
bug report.

So, I want to apply the PolyLine part of the patch to develop, does that
look right to you?


--
Sebastian Kuzminsky

[Christian Kohlöffel]

Yes, your right. Thank you for supporting. Feel free to apply the patch.

Regards Christian

--
--
You received this message because you subscribed to the Google
Groups-group  "dxf2gcode-dev".
To post a message, send mail to dxf2gc...@googlegroups.com
To unsubscribe, send mail to dxf2gcode-de...@googlegroups.com
See http://groups.google.de/group/dxf2gcode-dev?hl=en for more options
and the dxf2gcode project page at http://code.google.com/p/dxf2gcode/
---
You received this message because you are subscribed to the Google Groups "dxf2gcode-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to dxf2gcode-de...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Sebastian Kuzminsky]

I pushed Sebastian Reichel's PolyLine fix (but not the LWPolyLine fix,
since an equivalent fix is already present) to the develop branch.

On 03/29/2018 01:29 AM, 'Christian Kohlöffel' via dxf2gcode-dev wrote:
> Yes, your right. Thank you for supporting. Feel free to apply the patch.
> Regards Christian
>

> Sebastian Kuzminsky <s...@highlab.com <mailto:s...@highlab.com>> schrieb

> am Do., 29. März 2018, 01:31:
>
> Hello Christian, I got a bug report against version 20170925, related to
> the LWPolyLine fix you made recently (2bab0a20):
>
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=894206
>
> The patch proposed there fixes both the LWPolyLine bug you fixed, and (i
> think) the same bug in regular PolyLines.  I think there's no need for
> that LWPolyLine fix since your commit implements the same check, but
> probably the PolyLine part of the patch should go into develop?
>
> Unfortunately we don't have a DXF that demonstrates the PolyLine bug.
> The DXF that Sebastian Reichel attached to that debian bug imports
> correctly in both develop and in 20170925 with the patch from the debian
> bug report.
>
> So, I want to apply the PolyLine part of the patch to develop, does that
> look right to you?
>
>
> --
> Sebastian Kuzminsky
>
> --
> --
> You received this message because you subscribed to the Google
> Groups-group  "dxf2gcode-dev".
> To post a message, send mail to dxf2gc...@googlegroups.com

> <mailto:dxf2gc...@googlegroups.com>

> To unsubscribe, send mail to
> dxf2gcode-de...@googlegroups.com

> <mailto:dxf2gcode-dev%2Bunsu...@googlegroups.com>

> See http://groups.google.de/group/dxf2gcode-dev?hl=en for more options
> and the dxf2gcode project page at http://code.google.com/p/dxf2gcode/
> ---
> You received this message because you are subscribed to the Google
> Groups "dxf2gcode-dev" group.
> To unsubscribe from this group and stop receiving emails from it,
> send an email to dxf2gcode-de...@googlegroups.com

> <mailto:dxf2gcode-dev%2Bunsu...@googlegroups.com>.

> For more options, visit https://groups.google.com/d/optout.
>

> --
> --
> You received this message because you subscribed to the Google
> Groups-group "dxf2gcode-dev".
> To post a message, send mail to dxf2gc...@googlegroups.com
> To unsubscribe, send mail to dxf2gcode-de...@googlegroups.com
> See http://groups.google.de/group/dxf2gcode-dev?hl=en for more options
> and the dxf2gcode project page at http://code.google.com/p/dxf2gcode/
> ---
> You received this message because you are subscribed to the Google
> Groups "dxf2gcode-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to dxf2gcode-de...@googlegroups.com

> <mailto:dxf2gcode-de...@googlegroups.com>.

> For more options, visit https://groups.google.com/d/optout.

--
Sebastian Kuzminsky