python module name/install path

[Sebastian Kuzminsky]

I got this bug report from the debian folks:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=891029

The issue is that dxf2gcode installs top-level python modules with very
generic names like "core", "gui", and "globals". These are likely to
conflict/collide with the names of other python projects.

I think an easy, clean way to fix this would be to create a new
top-level module named "dxf2gcode" and move all the current modules to
be under that.

Then the imports within dxf2gcode would change like this:

- from core.point3d import Point3D
+ from dxf2gcode.core.point3d import Point3D

Any comments/objections to this? I'd be happy to prepare a patch or PR
that implements this. What's the best way for me to contribute patches
like this to the project?


--
Sebastian Kuzminsky

[Christian Kohlöffel]

Hi Sebastian, 

you can contribute that way, or I grant you developer rights and you commit it to the development branch. This is even my preferred way, since less work for me. However this is dependent on you, how much you want to contribute.

Regards Christian

--
--
You received this message because you subscribed to the Google
Groups-group  "dxf2gcode-dev".
To post a message, send mail to dxf2gc...@googlegroups.com
To unsubscribe, send mail to dxf2gcode-dev+unsubscribe@googlegroups.com
See http://groups.google.de/group/dxf2gcode-dev?hl=en for more options
and the dxf2gcode project page at http://code.google.com/p/dxf2gcode/
---
You received this message because you are subscribed to the Google Groups "dxf2gcode-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to dxf2gcode-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Sebastian Kuzminsky]

On 02/24/2018 11:11 AM, 'Christian Kohlöffel' via dxf2gcode-dev wrote:
> Hi Sebastian, 
> you can contribute that way, or I grant you developer rights and you
> commit it to the development branch. This is even my preferred way,
> since less work for me. However this is dependent on you, how much you
> want to contribute.

Hi Christian,

I gladly accept your offer of push access to your repo, thank you! My
SF username is seb_kuzminsky.

I am happy to do the technical work, but I don't want to hijack your
project or dictate the direction of development.

I therefore ask that you review my proposal(s) and either explicitly
accept them or else give me feedback on what you don't like about my
patches. I'll then redesign or rework them to be in line with what you
and the other developers want.

Sound good?


--
Sebastian Kuzminsky

[Christian Kohlöffel]

That's totally fine for me. We are not that formally and strict, so I am sure your patches don't need major rework. I will grant you access as soon as I am on my pc next time.

Regards Christian 

[Sebastian Kuzminsky]

On 02/24/2018 12:16 PM, 'Christian Kohlöffel' via dxf2gcode-dev wrote:
> That's totally fine for me. We are not that formally and strict, so I am
> sure your patches don't need major rework. I will grant you access as
> soon as I am on my pc next time.

Ping.

;-)


--
Sebastian Kuzminsky

[Sebastian Kuzminsky]

On 02/24/2018 12:16 PM, 'Christian Kohlöffel' via dxf2gcode-dev wrote:
> That's totally fine for me. We are not that formally and strict, so I am
> sure your patches don't need major rework. I will grant you access as
> soon as I am on my pc next time.

I see that I now have push access to the dxf2gcode repo on SF, thank you
Christian!

I pushed a branch named top-level-module:

https://sourceforge.net/p/dxf2gcode/sourcecode/ci/top-level-module/tree/

It's based on develop. It creates a new top-level python module named
"dxf2gcode" and moves all the existing modules into it (core, dxfimport,
globals, gui, and postpro).

It then updates all import statements so they find the modules in their
new locations, and updates the UI dscription file, the make_tr script,
and the st-setup script to match.

The diff is large and unwieldy, but largely mechanical and conceptually
simple.

I've tested the tip of that branch some: I can start dxf2gcode, import a
dxf, click around in the GUI, and emit g-code that runs on LinuxCNC. I
did not notice anything wrong Please let me know if there is any
additional testing I should do.

If you're happy with that, please either merge it into develop or tell
me explicitly that you accept this branch and I'll merge it into
develop. Either way is fine by me, just let me know. :-)


--
Sebastian Kuzminsky

[Christian Kohlöffel]

Hello Sebastian,

 

thanks for your great commit. I just tested it for functionality and didn’t see any issues with it at all. I do accept this branch and i would be happy if you could merge it into the development branch to continue further development.

 

Regards

Christian

--

--

You received this message because you subscribed to the Google

Groups-group  "dxf2gcode-dev".

To post a message, send mail to dxf2gc...@googlegroups.com

To unsubscribe, send mail to dxf2gcode-de...@googlegroups.com

See http://groups.google.de/group/dxf2gcode-dev?hl=en for more options

and the dxf2gcode project page at http://code.google.com/p/dxf2gcode/

---

You received this message because you are subscribed to the Google Groups "dxf2gcode-dev" group.

To unsubscribe from this group and stop receiving emails from it, send an email to dxf2gcode-de...@googlegroups.com.

[Christian Kohlöffel]

Hi Sebastian,

 

just added a fix for the ticket #97 to your branch. Please also push that to the development branch. I didn’t wanner Change my local repository to the original development branch since this required some Manual work.

 

Regards

Christian  

[Sebastian Kuzminsky]

On 03/16/2018 01:27 PM, 'Christian Kohlöffel' via dxf2gcode-dev wrote:
> Hi Sebastian,
>
> just added a fix for the ticket #97 to your branch. Please also push
> that to the development branch. I didn’t wanner Change my local
> repository to the original development branch since this required some
> Manual work.
>
> Regards
>
> Christian
>

> *Von: *Christian Kohlöffel <mailto:christian....@googlemail.com>
> *Gesendet: *Freitag, 16. März 2018 19:40
> *An: *dxf2gc...@googlegroups.com <mailto:dxf2gc...@googlegroups.com>
> *Betreff: *AW: [dxf2gcode-dev] python module name/install path

>
> Hello Sebastian,
>
> thanks for your great commit. I just tested it for functionality and
> didn’t see any issues with it at all. I do accept this branch and i
> would be happy if you could merge it into the development branch to
> continue further development.

Thanks for the review :-)

I updated my copy of the top-level-module branch to include your "empty
polyline" fix for #97, merged it into develop, and pushed the result to
sourceforge.


--
Sebastian Kuzminsky