[DuraSpace JIRA] (DS-4574) Upgrade DBCP dependency

[Hrafn Malmquist (LYRASIS JIRA)]

Hrafn Malmquist created an issue

DSpace / DS-4574 Upgrade DBCP dependency Issue Type: Improvement Affects Versions: 6.3, 7.0 Assignee: Unassigned Components: API Created: 23/Feb/21 6:32 PM Priority: Minor Reporter: Hrafn Malmquist The same version of Commons DBCP2 has been used since 2015. Version 2.1.1 was released in 2015. https://github.com/DSpace/DSpace/blob/b574fb141a9424d3d0776647b0fcba01173fd837/pom.xml#L1106 https://commons.apache.org/proper/commons-dbcp/changes-report.html Since then several minor releases have been released, last 2.8.0 on 2020-09-21. It is a simple quick win to upgrade. A review of the release changes in the link above should tell you something about the improvements, none are huge. But I think it's a good rule of thumb not to let too long pass without updating dependencies. Support for JDBC 4.2. (in Java 8) added in DBCP2 2.5.0 The underlying Apache Commons Pool library will get upgraded from v. 2.4.2 to 2.8.1 Various bug fixes Needs to be forked in the pom like is done for the postgres-driver based on Java version. I will submit a pull request soonish. See also. DS-4562 https://github.com/DSpace/DSpace/issues/3070 Add Comment

This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)

[Anonymous (LYRASIS JIRA)]

Issue was automatically transitioned when Hrafn Malmquist created pull request #3162 in GitHub

DSpace / DS-4574 Upgrade DBCP dependency

Change By: Hrafn Malmquist Status: Received Code Review Needed

Add Comment

[Tim Donohue (LYRASIS JIRA)]

Tim Donohue updated an issue

DSpace / DS-4574 Upgrade DBCP dependency

Change By: Tim Donohue Fix Version/s: 7.0

Add Comment

[Tim Donohue (LYRASIS JIRA)]

Tim Donohue commented on DS-4574

Re: Upgrade DBCP dependency Already fixed in 7.0, as this PR was merged: https://github.com/DSpace/DSpace/pull/3164 Will leave this ticket open temporarily though to see whether it gets fixed in 6.x as well.

Add Comment

[Alan Orth (LYRASIS JIRA)]

Alan Orth commented on DS-4574

Re: Upgrade DBCP dependency I tested the commons-dbcp2 and commons-pool2 updates in our DSpace 6.3 instance and they work (at least XMLUI browsing, item submission, REST API, and Discovery browse, Discovery index). A few comments for Hrafn Malmquist: I would recommend rebasing and squashing these two commits on top of the latest dspace-6_x branch so they merge more cleanly I would recommend amending the commit message to include DS-4574 (currently it is only in the GitHub pull request title) The current latest commons-pool version for Java 8 is 2.11.0

Add Comment

[Tim Donohue (LYRASIS JIRA)]

Tim Donohue closed an issue as Fixed

In order to close out the "7.0" Version in Jira (so that nothing new can be added to it), I need to close this ticket as fixed in 7.0. I realize it's still being backported to 6.4, but that will need to occur in a separate Jira ticket.  Sorry about that.

DSpace / DS-4574 Upgrade DBCP dependency

Change By: Tim Donohue Resolution: Fixed Status: Code Review Needed Closed

Add Comment