[dspace-tickets] [DuraSpace JIRA] (DS-2278) Error pages improperly formatted on certain url patterns

[Terry Brady (DuraSpace JIRA)]

Terry Brady created an issue

DSpace / DS-2278 Error pages improperly formatted on certain url patterns Issue Type: Bug Affects Versions: 5.0 Assignee: Unassigned Attachments: screenshot-1.png Components: XMLUI Created: 11/Nov/14 7:11 PM Environment: demo.dspace.org Priority: Minor Reporter: Terry Brady http://demo.dspace.org/xmlui/1111 and http://demo.dspace.org/xmlui/handle/1111 do not display a proper error page Creating a ticket per https://jira.duraspace.org/browse/DS-2273 Add Comment

This message was sent by Atlassian JIRA (v6.2.6#6264-sha1:ee76422)

[Terry Brady (DuraSpace JIRA)]

Terry Brady updated an issue

DSpace / DS-2278 Error pages improperly formatted on certain url patterns

Change By: Terry Brady Attachment: screenshot-1.png

Add Comment

[Terry Brady (DuraSpace JIRA)]

Terry Brady updated an issue

DSpace / DS-2278 Error pages improperly formatted on certain url patterns

Change By: Terry Brady Attachment: screenshot-2.png

Add Comment

[Tim Donohue (DuraSpace JIRA)]

Tim Donohue updated an issue

DSpace / DS-2278 Error pages improperly formatted on certain url patterns

Change By: Tim Donohue Fix Version/s: 5.0

Add Comment

[Tim Donohue (DuraSpace JIRA)]

Tim Donohue commented on DS-2278

Re: Error pages improperly formatted on certain url patterns Further explanation on the "redirect" fix for issue #2, based on discussion about this problem with mhwood & hpottinger: Essentially, the flow of an XMLUI request is somewhat like this: First, any external paths (passed directly on URL) are matched in the main Sitemap. Anything not matched there gets passed directly to the configured Theme Sitemap. The Theme Sitemap simply passes the "path" along to the Aspect Chain (and it becomes an internal Cocoon request), and the Aspect Chain processes aspects (internally) based on the path. So, by default all URL paths end up becoming "internal" Cocoon requests, and processed by the Aspect Chain...UNLESS they are matched by the main Sitemap (or alternatively the specific Theme's sitemap). As the Aspect Chain assumes that paths beginning with numbers refer to specific AspectIDs, the "chain processing" gets confused when a URL path starting with a number gets passed down to the Aspect Chain. Therefore, my "fix" was to ensure any paths that begin with a number are "matched" in the main SiteMap and redirected elsewhere (to ensure they never get processed by the Aspect Chain). The most logical redirect was to assume they are likely object identifiers and to redirect them to "/handle"

Add Comment

[Tim Donohue (DuraSpace JIRA)]

Tim Donohue updated an issue

DSpace / DS-2278

Error pages improperly formatted on certain url patterns

Change By: Tim Donohue Assignee: Tim Donohue Status: Volunteer Needed Accepted

Add Comment

[Tim Donohue (DuraSpace JIRA)]

Tim Donohue commented on DS-2278

Re: Error pages improperly formatted on certain url patterns There seems to be two underlying errors here, both of which actually seem to have been in the XMLUI for some time... Issue #1 When accessing the "/handle" path, DSpace seems to assume that you'll always send a [prefix]/[suffix]. So, if you don't pass a [suffix], then it causes errors. For example: http://demo.dspace.org/xmlui/handle/1234 - Returns a completely blank page because DSpace XMLUI has errorred out behind the scenes Issue #2 Paths that begin with a number (0-9) do NOT work properly in the XMLUI. It seems that the XMLUI forwards those paths on to its AspectMatcher, which wrongly assumes that the number references the index of an Aspect in the configured aspect chain (in xmlui.xconf). See this area of the code: https://github.com/DSpace/DSpace/blob/master/dspace-xmlui/src/main/java/org/dspace/app/xmlui/cocoon/AspectMatcher.java#L61 This issue can be seen by accessing any URL beginning with a number, although it results in slightly different displays based on whether that number actually corresponds to a valid AspectID, or not. For example: http://demo.dspace.org/xmlui/1 (1 is a valid AspectID, and you get an odd "The current URI (1) doesn't start with given prefix (1/)" error). http://demo.dspace.org/xmlui/1/notvalid (again 1 is a valid AspectID, but this time it results in a blank-looking page within the existing theme) http://demo.dspace.org/xmlui/1000 (1000 is not a valid AspectID, XMLUI gets confused and returns an un-themed page) http://demo.dspace.org/xmlui/1000/notvalid (again an un-themed page) http://demo.dspace.org/xmlui/0 (This page "seems" to work properly, but the reality is that it's not working either – notice the lack of anything in the side menu. In this case, AspectID=0 actually refers to the Page Not Found aspect, which is why it gets loaded.) I have a PR nearly ready to fix both of these XMLUI issues.

Add Comment

[Tim Donohue (DuraSpace JIRA)]

Tim Donohue updated an issue

DSpace / DS-2278

Error pages improperly formatted on certain url patterns

Proposed fixes are in this PR. I've tested it locally, but it could use more eyes & comments: https://github.com/DSpace/DSpace/pull/861 One note is that the only way I found to "fix" Issue #2 (see my previous comment) was to actually redirect those URLs. DSpace does NOT have any valid URLs that start with numbers, so I chose to redirect them all to the "/handle/" path. Therefore http://demo.dspace.org/xmlui/123/456 would now redirect to http://demo.dspace.org/xmlui/handle/123/456 . If the handle exists, the object would be returned. Otherwise the 404 page would be returned. Change By: Tim Donohue Status: Accepted Code Review Needed

Add Comment

[Tim Donohue (DuraSpace JIRA)]

Tim Donohue closed an issue as Fixed

PR #861 was merged into master and dspace-5_x for the 5.1 release.

DSpace / DS-2278 Error pages improperly formatted on certain url patterns

Change By: Tim Donohue Resolution: Fixed Reviewer: Hardy Pottinger Status: Code Review Needed Closed

Add Comment