[dspace-tickets] [DuraSpace JIRA] (DS-2683) Logging statistics through API only logs ip when using proxy

[Roeland Dillen (@mire) (DuraSpace JIRA)]

Roeland Dillen (@mire) created an issue

DSpace / DS-2683 Logging statistics through API only logs ip when using proxy Issue Type: Bug Assignee: Unassigned Created: 30/Jul/15 3:26 AM Priority: Minor Reporter: Roeland Dillen (@mire) The overloaded method org.dspace.statistics.SolrLogger#getCommonSolrDoc(org.dspace.content.DSpaceObject, java.lang.String, java.lang.String, java.lang.String, org.dspace.eperson.EPerson) as opposed to org.dspace.statistics.SolrLogger#getCommonSolrDoc(org.dspace.content.DSpaceObject, javax.servlet.http.HttpServletRequest, org.dspace.eperson.EPerson) only logs the ip is useProxies is enabled and something is filled in in X-Forwarded-For. This is because the entire block logging data derived from the IP is wrapped in if (isUseProxies() && xforwardedfor != null) while it should only be the determination of the ip. Luckily this code doesn't usually get triggered as usually the UsageEvent will contain a reference to the ServletRequest but someone will eventually use this code. Add Comment

This message was sent by Atlassian JIRA (v6.2.6#6264-sha1:ee76422)

[Roeland Dillen (@mire) (DuraSpace JIRA)]

Roeland Dillen (@mire) commented on DS-2683

Re: Logging statistics through API only logs ip when using proxy PR https://github.com/DSpace/DSpace/pull/1000

Add Comment

[Bram Luyten (@mire) (DuraSpace JIRA)]

Bram Luyten (@mire) updated an issue

DSpace / DS-2683

Logging statistics through API only logs ip when using proxy

Change By: Bram Luyten (@mire) Status: Received Code Review Needed

Add Comment

[Bram Luyten (@mire) (DuraSpace JIRA)]

Bram Luyten (@mire) assigned an issue to Bram Luyten (@mire)

DSpace / DS-2683 Logging statistics through API only logs ip when using proxy

Change By: Bram Luyten (@mire)

Assignee: Bram Luyten (@mire)

Add Comment

[Bram Luyten (@mire) (DuraSpace JIRA)]

Bram Luyten (@mire) updated an issue

DSpace / DS-2683 Logging statistics through API only logs ip when using proxy

Change By: Bram Luyten (@mire)

Labels: has-pull-request

Add Comment

[Bram Luyten (@mire) (DuraSpace JIRA)]

Bram Luyten (@mire) commented on DS-2683

Re: Logging statistics through API only logs ip when using proxy +1 looks good, should be good for merging when another committer approves.

Add Comment

[Tim Donohue (DuraSpace JIRA)]

Tim Donohue commented on DS-2683

Re: Logging statistics through API only logs ip when using proxy

As noted in the PR#1000, I believe this has already fixed on the "master" branch via a separate PR. https://github.com/DSpace/DSpace/blob/master/dspace-api/src/main/java/org/dspace/statistics/SolrLoggerServiceImpl.java#L287 However, I'd appreciate verification of that before closing this ticket.

Add Comment

This message was sent by Atlassian JIRA (v7.10.0#710001-sha1:0399717)

[Tim Donohue (LYRASIS JIRA)]

Tim Donohue closed an issue as Fixed

Closing as fixed, as the related PR was also closed as fixed.

DSpace / DS-2683

Logging statistics through API only logs ip when using proxy

Change By: Tim Donohue Resolution: Fixed Status: Code Review Needed Closed

Add Comment

This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)