[DuraSpace JIRA] (DS-3281) Submission made via REST API does not trigger collection workflow approval process.

[Emilio Lorenzo (DuraSpace JIRA)]

Emilio Lorenzo created an issue

DSpace / DS-3281 Submission made via REST API does not trigger collection workflow approval process. Issue Type: Bug Affects Versions: 5.5 Assignee: Unassigned Components: REST API Created: 03/Aug/16 11:34 AM Priority: Minor Reporter: Emilio Lorenzo Submisisions made through REST API (POST/item method) don´t get into workflow-approvals Add Comment

This message was sent by Atlassian JIRA (v7.0.0#70107-sha1:6cd5e8d)

[Adan Roman (DuraSpace JIRA)]

Adan Roman updated an issue

DSpace / DS-3281 Submission made via REST API does not trigger collection workflow approval process.

Change By: Adan Roman Attachment: DS-3281.patch

Add Comment

[Adan Roman (DuraSpace JIRA)]

Adan Roman commented on DS-3281

Re: Submission made via REST API does not trigger collection workflow approval process. I Attached a fast solution

Add Comment

[Martin Walk (DuraSpace JIRA)]

Martin Walk commented on DS-3281

Re: Submission made via REST API does not trigger collection workflow approval process.

I applied the patch to a DSpace 5.5 release and it works as expected. If a collection approval workflow is defined, the items placed in the collection via REST API do trigger the workflow, if no workflow is defined for a collection, items added via REST API are archived immediately. Thank you very much! Best regards, Martin Walk.

Add Comment

[Martin Walk (DuraSpace JIRA)]

Martin Walk commented on DS-3281

Re: Submission made via REST API does not trigger collection workflow approval process.

There should perhaps be an option - as with the command line importers - to send a submission through the collection's workflow or to bypass the workflow? I can see usage scenarios for both options.

Add Comment

[Adan Roman (DuraSpace JIRA)]

Adan Roman commented on DS-3281

Re: Submission made via REST API does not trigger collection workflow approval process.

Perhaps if the rest user is administrator. Normal user should follow workflows.

Add Comment

[Adan Roman (DuraSpace JIRA)]

[Adan Roman (DuraSpace JIRA)]

Adan Roman updated an issue

DSpace / DS-3281

Submission made via REST API does not trigger collection workflow approval process.

Change By: Adan Roman Comment:

Perhaps if the rest user is administrator. Normal user should follow workflows.

Add Comment

[Tim Donohue (DuraSpace JIRA)]

Tim Donohue updated an issue

DSpace / DS-3281 Submission made via REST API does not trigger collection workflow approval process.

Flagging as "needs volunteer" as we'd need a volunteer to turn the attached patch into a GitHub Pull Request: https://wiki.duraspace.org/display/DSPACE/Code+Contribution+Guidelines Change By: Tim Donohue Status: Received Volunteer Needed

Add Comment

[Tim Donohue (DuraSpace JIRA)]

Tim Donohue updated an issue

DSpace / DS-3281 Submission made via REST API does not trigger collection workflow approval process.

Change By: Tim Donohue Labels: has-patch

Add Comment

[Adan Roman (DuraSpace JIRA)]

Adan Roman commented on DS-3281

Re: Submission made via REST API does not trigger collection workflow approval process. https://github.com/DSpace/DSpace/pull/1657

Add Comment

[Anonymous (DuraSpace JIRA)]

Issue was automatically transitioned when Arvo Consultores y Tecnología. S.L created pull request #1657 in GitHub

DSpace / DS-3281

Submission made via REST API does not trigger collection workflow approval process.

Change By: Arvo Consultores y Tecnología. S.L Status: Volunteer Code Review  Needed

Add Comment

[Tim Donohue (DuraSpace JIRA)]

Tim Donohue commented on DS-3281

Re: Submission made via REST API does not trigger collection workflow approval process. While I agree this is a bug, I'm now rethinking whether the proposed solution is enough. There also is currently not a way to progress an item through the workflow process via the REST API (which is likely why, when it was created, the REST API didn't involve the workflow process). So, if you place the item into Workflow via the REST API, you must wait until it is approved by some other means. I suspect this may be part of the larger issue that our REST API is just lacking in features. This is something that we are / will be working to resolve at a much larger scale in DSpace 7, see https://wiki.duraspace.org/display/DSPACE/DSpace+7+UI+Working+Group

Add Comment

[Martin Walk (DuraSpace JIRA)]

Martin Walk commented on DS-3281

Re: Submission made via REST API does not trigger collection workflow approval process.

The intended use in our case was not to provide an alternative UI on top of the REST API, but to allow submissions from other systems to DSpace (e.g. provide a possibilty to submit a release of a GitHub project, submit a publication from another publication system, etc.) via the REST API and then accept or reject the submission through the regular submission review workflow from the regular DSpace UIs by our curators. Another solution might be to provide a flag that decides whether the submission via REST API is published straight away or is added to the submission review process. I agree though, that this is less pressing now, as DSpace 7 will probably provide a solution for it.

Add Comment

[Martin Walk (DuraSpace JIRA)]

Martin Walk commented on DS-3281

Re: Submission made via REST API does not trigger collection workflow approval process.

Is there a possible security issue, where someone could place an item directly in a collection, while bypassing the approval workflow?

Add Comment

[Tim Donohue (LYRASIS JIRA)]

Tim Donohue updated an issue

DSpace / DS-3281

Submission made via REST API does not trigger collection workflow approval process.

Change By: Tim Donohue Security: Requires Login

Add Comment

This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)