[DuraSpace JIRA] (DS-4135) Citation_* tags should contain plain UTF-8, without escaping

[Bram Luyten (Atmire) (DuraSpace JIRA)]

Bram Luyten (Atmire) created an issue

DSpace / DS-4135 Citation_* tags should contain plain UTF-8, without escaping Issue Type: Bug Affects Versions: 5.10, 6.3, 4.9 Assignee: Unassigned Created: 05/Jan/19 7:12 AM Fix Versions: 6.4, 5.11, 4.10 Priority: Minor Reporter: Bram Luyten (Atmire) Following was reported by folks at Google Scholar. Observed behaviour Look at an item where one of the authors has special characters in the name, for example,  http://demo.dspace.org/xmlui/handle/10673/314 Go into "view source" and go to the HEAD section where the META tags are exposed. Compare what you see for authors in dc.creator, with the citation_* tags, like citation_author In creator, it's correct: meta name="DC.creator" content="ètésteinî"  In citation_author, unwanted escaping is added. meta content="ètésteinî" name="citation_author" Desired behaviour meta name="DC.creator" content="ètésteinî"  meta content="ètésteinî" name="citation_author" Add Comment

This message was sent by Atlassian JIRA (v7.10.0#710001-sha1:0399717)

[Bram Luyten (Atmire) (DuraSpace JIRA)]

Bram Luyten (Atmire) assigned an issue to Bram Luyten (Atmire)

DSpace / DS-4135 Citation_* tags should contain plain UTF-8, without escaping

Change By: Bram Luyten (Atmire) Assignee: Bram Luyten (Atmire)

Add Comment

[Bram Luyten (Atmire) (DuraSpace JIRA)]

Bram Luyten (Atmire) updated an issue

DSpace / DS-4135 Citation_* tags should contain plain UTF-8, without escaping Change By: Bram Luyten (Atmire)

Following was reported by folks at Google Scholar.

*Observed behaviour*

Look at an item where one of the authors has special characters in the name, for example,  [http://demo.dspace.org/xmlui/handle/10673/314] Go into "view source" and go to the HEAD section where the META tags are exposed. Compare what you see for authors in dc.creator, with the citation_* tags, like citation_author In creator, it's correct: meta name="DC.creator" content="ètésteinî"  In citation_author, unwanted escaping is added.

{code:java} < meta content="&egrave;t&eacute;stein&icirc;" name="citation_author" > {code} *Desired behaviour*

meta name="DC.creator" content="ètésteinî"  meta content="ètésteinî" name="citation_author"

Add Comment

[Bram Luyten (Atmire) (DuraSpace JIRA)]

Bram Luyten (Atmire) updated an issue

DSpace / DS-4135 Citation_* tags should contain plain UTF-8, without escaping

Change By: Bram Luyten (Atmire)

Status: Received Code Review Needed

Add Comment

[Bram Luyten (Atmire) (DuraSpace JIRA)]

Bram Luyten (Atmire) commented on DS-4135

Re: Citation_* tags should contain plain UTF-8, without escaping DSpace-6_x https://github.com/DSpace/DSpace/pull/2317 Writing the tags as text was the only approach I could find, as disabling output escaping is not allowed on attributes in xslt by default, cfr  https://stackoverflow.com/questions/2921123/xsl-how-to-disable-output-escaping-for-an-attribute

Add Comment

[Bram Luyten (Atmire) (DuraSpace JIRA)]

Bram Luyten (Atmire) commented on DS-4135

Re: Citation_* tags should contain plain UTF-8, without escaping

Recap of the Github PR discussion: JSPUI is not affected Mirage 1 is affected & I added the fix there as well After the merge for 6.x, also remains to be fixed in 5.x and 4.x

Add Comment

[Alan Orth (DuraSpace JIRA)]

Alan Orth commented on DS-4135

Re: Citation_* tags should contain plain UTF-8, without escaping

Good catch, Bram Luyten (Atmire)! I've just tested the 6.4 patch with one item in our repository with non-ASCII (Vietnamese) text and confirm that it works. Before: <meta content="Thu hoạch v&agrave; bảo quản c&agrave; ph&ecirc; ch&egrave; đ&uacute;ng kỹ thuật (Harvesting and storing Arabica coffee)" name="citation_title"> After: <meta name="citation_title" content="Thu hoạch và bảo quản cà phê chè đúng kỹ thuật (Harvesting and storing Arabica coffee)" />

Add Comment

This message was sent by Atlassian Jira (v8.4.1#804002-sha1:94e96d6)

[Alan Orth (LYRASIS JIRA)]

Alan Orth commented on DS-4135

Re: Citation_* tags should contain plain UTF-8, without escaping

There is a pull request that partially fixes this for some use cases: https://github.com/DSpace/DSpace/pull/2317 I tested the pull request with 6.4-SNAPSHOT and it fixes non-ASCII (Vietnamese) text in the citation tags, though it was pointed out that text with quotes needs to be escaped. I proposed merging this for now and creating a new issue for the quotation bug.

Add Comment

This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)