ORCID support patch

[ottawad...@gmail.com]

I am writing to you to inquire about expanded ORCID support patch.

I have attempted to apply the patch to a DSpace 6.3 (JSPUI) installation, and there were a few issues in getting the patch to apply correctly.

• I noticed that one of the properties for dspace.cfg is orcid.api.url = https://pub.orcid.org/v2.1, which is apparently deprecated now
• When attempting to compile after applying and merging the patch changes, the error package org.orcid.jaxb.model.record_v2 does not exist showed, suggesting a missing dependency
• Searches indicate that missing dependency may be https://mvnrepository.com/artifact/org.orcid/orcid-model (Is it the correct one? Should adding the dependency be included in the patch?)

• After adding this dependency, a few dependency convergence errors occurred, but those specific dependencies can be excluded in the pom.xml definitions

• Further errors after resolving all the above said things such as cannot find symbols NameType, KeywordType, ExternalId, UrlResearcherType
• Those classes don’t exist in the current dependency’s repository https://github.com/ORCID/orcid-model/tree/master/src/main/java/org/orcid/jaxb/model/record_v2

• But in a former repository https://github.com/DSpace/orcid-jaxb-api, before it moved to v3,
  those classes listed are present in the repository https://github.com/DSpace/orcid-jaxb-api/tree/632aa9cbd1d9b98531aed022a28fdbdfdd56f1c8/src/main/java/org/orcid/jaxb/model/record_v2

I hope that is enough information on what has been done so far, my question now is, is an ORCID dependency supposed to be included in the patch? If so, which one? Is the extended ORCID support patch possibly out of date now?

Thank you,

[Bollini Andrea]

Hi,
sorry for the late reply.

> I noticed that one of the properties for dspace.cfg is

orcid.api.url= https://pub.orcid.org/v2.1, which is apparently
deprecated now

ORCID v2.1 is not the current version of the API but it is still
supported a sunset deadline for it is not yet set. Version 3 of the
ORCID API are supported in the coming DSpace 7 and right now in DSpace-
CRIS all the versions.


Can you provide more details about how you have applied the patch to
your existing DSpace JSPUI 6.3 code base?

I guess that you have started from this PR
https://github.com/DSpace/DSpace/pull/2710

the easier approach could be to start from the dspace-6.x branch that
already include it https://github.com/DSpace/DSpace/tree/dspace-6_x

As you can check here

https://github.com/4Science/DSpace/blob/DS-2715_6-x/dspace-api/pom.xml#L713-L717

the orcid model dependency has an org.dspace groupId so this is the
artifact that you are looking for
https://mvnrepository.com/artifact/org.dspace/orcid-jaxb-api/2.1.0

at the time of the patch there were not yet an official orcid artifact
under the org.orcid group id

Best regards,
Andrea

> --
> All messages to this mailing list should adhere to the Code of
> Conduct: https://www.lyrasis.org/about/Pages/Code-of-Conduct.aspx
> ---
> You received this message because you are subscribed to the Google
> Groups "DSpace Technical Support" group.
> To unsubscribe from this group and stop receiving emails from it,
> send an email to dspace-tech...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/dspace-tech/817fd8b4-f361-4f46-bdad-b5385f029abbn%40googlegroups.com
> .
>

--
Questo messaggio e' stato analizzato da Libraesva ESG ed e' risultato non infetto.
This message was scanned by Libraesva ESG and is believed to be clean.