Drupal 7 and SSP 1.7

28 views
Skip to first unread message

Steve Moitozo II

unread,
Feb 7, 2011, 3:05:18 PM2/7/11
to Drupal SimpleSAMLphp integration
Gentlemen,

I've taken the simplesamlphp_auth module for Drupal through another
revision so that it works with Drupal 7. I have tested my work against
SimpleSAMLphp v1.7 as well and everything is working. I haven't tested
against SSP 1.6 but I see no reason for concern. I can do this if you
think I should.

I haven't checked my code into SVN yet since the current trunk should
probably be packaged for release to support Drupal 6 and SSP 1.6.
Perhaps a branch should be defined for it before we make the new
release for Drupal 7.

Thoughts?

-S2
--
Steve Moitozo II
Engineer
SIL Global Technology Services
office: +1 (704) 256-0407
skype: smoitozo

Andreas Åkre Solberg

unread,
Feb 8, 2011, 5:21:49 AM2/8/11
to drupalsi...@googlegroups.com
On 7. feb.2011, at 21:05, Steve Moitozo II wrote:

> Gentlemen,
>
> I've taken the simplesamlphp_auth module for Drupal through another
> revision so that it works with Drupal 7. I have tested my work against
> SimpleSAMLphp v1.7 as well and everything is working. I haven't tested
> against SSP 1.6 but I see no reason for concern. I can do this if you
> think I should.
>
> I haven't checked my code into SVN yet since the current trunk should
> probably be packaged for release to support Drupal 6 and SSP 1.6.
> Perhaps a branch should be defined for it before we make the new
> release for Drupal 7.
>
> Thoughts?

Great news Steve!

I also got some news. I just committed a patch to drupalsimplesamlphp. It should work with drupal 6.x and simplesamlphp 1.7.x. It also fixes several bugs, and support for SAML logout. I am unsure if it is compatible with 7.x.

This work have been done by Thomas Kulvik, NyMedia AS, Norway; sponsored by UNINETT.

I've not looked at or tested the code my self, therefore I'd be very happy if anyone could test this, to see how it works. If it appears to work ok, we may offer a zip download.

Steve, it is unfortunate that this patch crosses your work. Could you check your branch up against this new version, and see if it differs much?


We probably need someone to be responsible for maintaining this module... any volunteers? May be we could make it an official drupal module, hosted on their site.

Andreas

Steve Moitozo II

unread,
Feb 8, 2011, 11:47:02 AM2/8/11
to drupalsi...@googlegroups.com
Andreas and all,

I'd be willing to take the lead on maintaining this module.

Here are the steps that I think need to happen in short order:

- I'll review Thomas's code and see what needs to be merged into my
latest work.
- Branch the code according to Drupal version, e.g., Drupal 6, Drupal 7,
etc.
- Offer a zip download for Drupal 6
- Merge in my new code which adds support for Drupal 7
- Offer a zip download for Drupal 7
- Get the module included on the Drupal modules site
I need to see exactly what Drupal requires for this

Is everyone OK with this (any questions, comments, concerns)? If this
sounds good, is there any type of baton passing ceremony that needs to
happen before I can do all this?

Also, is there anyone on this list that would like to help by taking on
some role(s) like documentation, code review, testing, etc?

-S2
--
Steve Moitozo II
Engineer
SIL Global Technology Services
office: +1 (704) 256-0407
skype: smoitozo

Andreas Åkre Solberg

unread,
Feb 14, 2011, 9:58:44 AM2/14/11
to drupalsi...@googlegroups.com, Steve Moitozo II

On 8. feb. 2011, at 17.47, Steve Moitozo II wrote:

> Andreas and all,
>
> I'd be willing to take the lead on maintaining this module.

That is great news.

> Here are the steps that I think need to happen in short order:
>
> - I'll review Thomas's code and see what needs to be merged into my latest work.
> - Branch the code according to Drupal version, e.g., Drupal 6, Drupal 7, etc.
> - Offer a zip download for Drupal 6
> - Merge in my new code which adds support for Drupal 7
> - Offer a zip download for Drupal 7
> - Get the module included on the Drupal modules site
> I need to see exactly what Drupal requires for this

That sounds like an excellent plan. If you're able to do this, I'm sure there are alot of people (including me) that would appreciate it.

> Is everyone OK with this (any questions, comments, concerns)? If this sounds good, is there any type of baton passing ceremony that needs to happen before I can do all this?

Send me your google account id, and feel free to go ahead. Then update the credits header of the source code to indicate that you are the main contributor and project leader.

Again, thanks!

Andreas

Reply all
Reply to author
Forward
0 new messages