Move ResourceHolder into java-util

[Charles Allen]

All, there's a PR https://github.com/metamx/java-util/pull/51 in java-util to add some more deterministic resource handling. As part of the PR it adds an interface to java-util very similar to what's in druid.

I would like to not have multiple classes that do effectively the same thing. As such, I am proposing moving the ResourceHandler style of interface into java-util and deprecating the ResourceHolder in druid.

Any thoughts on the matter would be appreciated.

[Eric Tschetter]

I am against the change because of the pain already experienced when dealing with the external libs.  I think we should be moving more stuff *into* Druid proper not out of it.

--Eric

--
You received this message because you are subscribed to the Google Groups "Druid Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to druid-development+unsubscribe@googlegroups.com.
To post to this group, send email to druid-development@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/druid-development/8c4db1b9-2015-474f-bfef-8295bfda5a9e%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Charles Allen]

I'm not a fan of having duplicate interfaces that do the exact same thing, but I think if the situation were reversed, and java-util had the interface before druid.io, then the argument I could still hear @Eric make would be to make an interface in druid and do a bridge to the external lib if needed. So ok, two different interfaces sounds like what it will be.

[Roman Leventov]

I've changed the PR, so now it doesn't have "duplicate" ResourceHandler aiming to supersede Druid's ResourceHandler. It has just a specialized, not generic class MappedByteBufferHandler, unrelated to Druid's ResourceHandler. It is still not moving stuff inside Druid but it's neither moving stuff outside Druid now.

To view this discussion on the web visit https://groups.google.com/d/msgid/druid-development/c1c8550b-ccf1-4b28-a3a2-a3cfa01a412d%40googlegroups.com.