delete/remove is not exposed via AbstractDAO

[Ryan Kennedy]

I was surprised to notice that there's no delete/remove method on AbstractDAO in dropwizard-hibernate. There's a delete(Object) method in org.hibernate.Session, which AbstractDAO has a handle to. Does anyone know if there's a history to why there's no way to remove objects using AbstractDAO?

Is anyone using dropwizard-hibernate? I wonder how the omission of a pretty basic feature could have gone unaddressed for so long unless nobody's actually using it.

Ryan

[Ryan Kennedy]

I suppose everyone's probably calling currentSession().delete(entity) inside of their DAO's, instead.

Ryan

[Jérémie Panzer]

Yes, at least that's what I'm doing.

https://github.com/Athou/commafeed/blob/master/src/main/java/com/commafeed/backend/dao/GenericDAO.java

[Chris Micali]

We an abstract DAOBase that extends AbstractDAO that adds delete, along with a few more helpers.

[Carlo Barbara]

Yeah, that's what we have done too

--
You received this message because you are subscribed to the Google Groups "dropwizard-user" group.
To unsubscribe from this group and stop receiving emails from it, send an email to dropwizard-us...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Trevor Mack]

If a bunch of people are just adding this functionality should we look at adding it to the source? Was there a reason not to have this helper by default in AbstractDAO?