jsunittest IE fixes

0 views
Skip to first unread message

nlloyds

unread,
Mar 1, 2009, 12:58:32 PM3/1/09
to Dr Nic's JavaScript projects
I sent a pull request for jsunittest on github. Some of the tests had
trailing commas which IE did not handle gracefully.

Also, the testSummary test was failing on the logger tests in IE. I
tracked this down to the use of String.specialChar[match[0]] in
JsUnitTest.inspect(). I couldn't find any reference to the specialChar
property of String in the code or on the web, so I just changed it to
use match[0] instead and it appears to work. Is there something I'm
missing here?

Thanks,

Nathan

Choan Gálvez

unread,
Mar 1, 2009, 6:16:32 PM3/1/09
to drnic-javasc...@googlegroups.com

Hi.

About the `specialChar` thing, the problem is that it's not defined
(unless you're using the Prototype library).

It's used to show special chars on inspection of values (otherwise \n,
etc. would be invisible). And I **need** to see them.

Please see my patch at <http://github.com/choan/jsunittest/commit/7a543abba58489224b0119567caca97fac681ea1
>.

BTW, I'm afraid that drnic is not listening on this list. Are you
really here, drnic?
--
Choan

nlloyds

unread,
Mar 1, 2009, 8:26:38 PM3/1/09
to Dr Nic's JavaScript projects
Choan,

On Mar 1, 5:16 pm, Choan Gálvez <choan.gal...@gmail.com> wrote:
> Hi.
>
> About the `specialChar` thing, the problem is that it's not defined  
> (unless you're using the Prototype library).
>
> It's used to show special chars on inspection of values (otherwise \n,  
> etc. would be invisible). And I **need** to see them.

Yes, I thought it was left over from Prototype, though that property
is not documented on the Prototype web site (I should know this, I use
Prototype every day.)

> Please see my patch at <http://github.com/choan/jsunittest/commit/7a543abba58489224b0119567ca...

Great. I was not aware that you had a more up-to-date repo. I'll start
following that instead.

Thanks,

Nathan
Reply all
Reply to author
Forward
0 new messages