0.6.0 Beta issue with thead and tbody over page break

[William Jensen]

   I like the new beta release but I note that when a page breaks inside a table with <thead>, <tbody> and no <tfoot> set the bottom of the first page table is not closed(missing bottom of the cell row). Then the new <thead> on the following page is missing the top line of the table. 

this is with using the following in the CSS file:

table {page-break-inside:auto;}
tr    {page-break-inside:avoid; page-break-after:auto;}

[BrianS]

I have, so far, been unable to reproduce the issue. It would help to have some sample HTML that exhibits the problem when rendered by dompdf.

[William Jensen]

I have attached the files that I am generating the PDF's from this is a modified file based on openCart 1.5.4.1 admin invoice.

[William Jensen]

Fix found first the table not closing from page break

Found if I changed the CSS files

border-collapse: collapse;

to

border-spacing: -1px;

Then to fix the missing top on following page:

From my .product {

Moved

border-top: 1px solid #DDDDDD;

To new

thead {

border-top: 1px solid #DDDDDD;

}

So looks like border-collapse: collapse; is not working for tables or there is some other bug.

[BrianS]

Can you post the actual HTML rendered by dompdf? The template is ok, but then I have to go through and fill in the variable references. You can call $dompdf->output_html() after loading the document to get a copy of the HTML dompdf is using.

[William Jensen]

I have attached the Old_invoice.pdf and fixed file with the css changes listed above see Invoice_example.pdf. Also note this is running new DOMPDF 0.6.1 to get inline php for page number to work. I see from other discussion that css border-collapse: collapse; was a issue so that might be the problem with the bottom of the first page table the top of the new thead should have a top add automatic as that is a normal part of using <thead>. To work around I moved the css border-top and add a new css class for  <tead> with the border-top in-side. This fixed my problem.

[William Jensen]

Opps for got to past the html file here is the file. 

[William Jensen]

Ignore the last file I did the wrong thing

[BrianS]

OK, now I'm seeing it. I think the issue is specific to your styling. Some of it may be how we've implemented collapsible borders.

You see a similar issue when printing from Firefox on the second page. The more straightforward fix for this would be to keep your original CSS and apply a table border. With table-collapse set you don't have to worry about overly-large borders because they should combine.

The missing border on the first page does appear to possibly be a bug. I couldn't really find an acceptable solution to that problem, but I'll keep at it.

Of course, you have a work-around so you may not need to do anything moving forward unless you run into other issues.

[William Jensen]

Well my work around is works great just letting you know what I found and best of luck I look forward to enjoying this for a long time. Keep up the great work.