Fast clearing content

[Cezary]

Hello,

Before adding content to the container can be cleaned of its contents.
The DA is replaceContent function. With curiosity piece:

DOMAssistant.clearHandlers.apply(this);
this.innerHTML = "";
return DOMAssistant.Content.addContent.call(this, content);

replaced Excerpt:

var e = this.cloneNode(false);
this.parentNode.replaceChild(e, this);
return DOMAssistant.Content.addContent.call(e, content);

and came to me that innerHTML is not always faster. Particularly in
Firefox. After making changes, cleaning works much faster in Firefox
and in some cases in IE. In Safari and Opera and the innerHTML method,
which described the act as quickly.

What do you think?

--
Regards,
Cezary

[chenghong]

Hi there,

Good suggestion. I agree that performance could generally be faster in
your method. However, I'm also concerned about cloneNode not being
able to copy over event handlers or modified / custom attributes. I
have some scenarios in mind and I'll test them out before getting back
to you.

Thanks!

Cheers,
chenghong

[Cezary]

On 30 Kwi, 17:59, chenghong <chengh...@gmail.com> wrote:
> Hi there,
>
> Good suggestion. I agree that performance could generally be faster in
> your method. However, I'm also concerned about cloneNode not being
> able to copy over event handlers or modified / custom attributes. I
> have some scenarios in mind and I'll test them out before getting back
> to you.

Check results. I find the method is quite fast.

One more thing. Do not add the amount of code that solve the problem
with the cache in IE, when it comes to AJAX type GET queries? For
example:

if (method === "GET") {
XMLHttp.setRequestHeader("Cache-Control", "no-cache");
XMLHttp.setRequestHeader("If-Modified-Since", "Wed, 31 Dec
1980 00:00:00 GMT");
XMLHttp.setRequestHeader("Expires", "Wed, 31 Dec 1980
00:00:00 GMT");
}

Just before:

if (method === "POST") {
[...]

Maybe someone will suggest something.

> Thanks!

You welcome!

> Cheers,
> chenghong

--
Regards,
Cezary

[chenghong]

Hi,

The content clearing method you suggested is fast, but events binded
to the element would be lost. The hassles of reattaching events seem
to wipe off the benefits of cloneNode. I'm open to suggestions though.

As for your second suggestion, perhaps an easier way is to append a
timestamp to the GET query string?


Cheers,
chenghong

[Cezary]

On 7 Maj, 15:52, chenghong <chengh...@gmail.com> wrote:
> Hi,

Hi,

> The content clearing method you suggested is fast, but events binded
> to the element would be lost. The hassles of reattaching events seem
> to wipe off the benefits of cloneNode. I'm open to suggestions though.

I wonder, since the contents of the container clean, after which the
events are still needed?

> As for your second suggestion, perhaps an easier way is to append a
> timestamp to the GET query string?

Is easier? I do not know. Most importantly, the effect is the same.

--
Regards,
Cezary

[chenghong]

> I wonder, since the contents of the container clean, after which the
> events are still needed?

Yes, events should still be intact. You want to clear the contents of
an element, not the element itself.

chenghong

[Cezary]

On 15 Maj, 12:30, chenghong <chengh...@gmail.com> wrote:
> > I wonder, since the contents of the container clean, after which the
> > events are still needed?
>
> Yes, events should still be intact. You want to clear the contents of
> an element, not the element itself.

But the element is made up not only text, but also tags. So remove all
of the container, together with the events added into the elements,
because they are no longer needed.

On the other hand, the DA would be good to see function to swap two
classes.

--
Regards,
Cezary

[chenghong]

You mean toggling a class on/off, or replacing a class with another?

If it's the later, replaceClass(classA, classB) is currently
available.

I have also thought of adding a toggleClass method.


Cheers,
chenghong

[Cezary]

On 15 Maj, 16:59, chenghong <chengh...@gmail.com> wrote:
> You mean toggling a class on/off, or replacing a class with another?
>
> If it's the later, replaceClass(classA, classB) is currently
> available.
>
> I have also thought of adding a toggleClass method.

I thought the conversion of one class to another. Yes, toggleClass
would be very usefull.