RE: bug in domMenu 0.3.5 [fixed]

[Dan Allen]

Yep, I just got the same bug report from a couple of other people and
have updated it in SVN HEAD. I think it is enough to just say:

if (in_id > 0) {
}

because javascript will do the conversion automatically and all values
except numbers return false (such as null, null string, lamda function
or NaN).

I realized that I didn't have strict javascript checking on, so I will
be sure to enable on all browser instances in the future.

Thanks again!

/dan

lexs...@newel.net wrote:
> Submitted by: Alexandre SIMON <lexs...@newel.net> on Friday, February 10th, 2006 @ 6:36:31 am (-0500)
>
> Online Form Fields
> ------------------
>
> Url:
> http://alex.zybar.net
>
> Message:
> DomMenu calls domLib_clearTimeout with improper argument types.
>
> I didn't have time to watch dommenu code so I protected domLib.js with a
> parseInt :
>
>
> function domLib_clearTimeout(in_id)
> {
> if (!domLib_hasBrokenTimeout)
> {
> if (parseInt(in_id)) {
> clearTimeout(in_id);
> }
> }
> else
> {
> if (domLib_timeoutStates.has(in_id))
> {
> clearTimeout(domLib_timeoutStates.get(in_id).get('timeoutId'))
> domLib_timeoutStates.remove(in_id);
> }
> }
> }
>
>
>
> Client Variables
> ----------------
>
> HTTP_USER_AGENT:
> Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8) Gecko/20060111 Debian/1.5.dfsg-3bpo1 Firefox/1.5
>
>

--
Daniel Allen
Registered Linux User #231597

Mojavelinux.com: Open Source Advocacy
http://www.mojavelinux.com

While I make a strong effort to keep up with my email on a daily basis,
life and work come first and, at times, keep me away from my mail for a
while. If you contact me and then don't hear back for more than a week,
it is very likely that I am excessively backlogged or the message was
caught in the filters. Please don't hesitate to resend a message if
you feel that it did not reach my attention.