Bug? django.contrib.auth.forms using User model by importing from auth.models instead of get_user_model()

[Davor Lučić]

Hello,

I have issues using custom user model and forms from contrib.auth.forms

When using `UserCreationForm` it says `auth_user table does not exists` which is expected since i have different user model.

Looking at the code, some pieces of code use `get_user_model` and `UserModel` while model forms use `User` imported from `auth.models`.

For example:

https://github.com/django/django/blob/master/django/contrib/auth/forms.py#L10

https://github.com/django/django/blob/master/django/contrib/auth/forms.py#L86

If i use UserModel there it seems to work fine. Would this be considered a bug? 

Just wanted to check before creating a ticket.

Thank you,

Davor

[Tim Graham]

The documentation says you need to rewrite UserCreationForm for a custom user model: https://docs.djangoproject.com/en/stable/topics/auth/customizing/#custom-users-and-the-built-in-auth-forms.

[Davor Lučić]

Fair enough, I guess subclassing it makes more sense, I saw that it uses `USERNAME_FIELD`[1] so I assumed it could use the custom model by default too, but I guess you can have completely different models and that could create some confusion.

Anyway, sorry to take you time and thanks for quick response,

Cheers!

1: https://github.com/django/django/blob/master/django/contrib/auth/forms.py#L92