[Django] #24577: Restrict extending and including to require templates from the same engine.

10 views
Skip to first unread message

Django

unread,
Apr 3, 2015, 12:48:12 PM4/3/15
to django-...@googlegroups.com
#24577: Restrict extending and including to require templates from the same engine.
---------------------------------+--------------------
Reporter: prestontimmons | Owner: nobody
Type: Bug | Status: new
Component: Template system | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+--------------------
If two Django engines are configured and a template object from the first
engine is used as an include or extends in a template from the second
engine, it's not clear which engine will be used if the template object
also happens to include or extend other templates.

Per discussion with Aymeric, it sounds like the least ambiguous behavior
it to raise an exception if an included or extended template has a
different engine than that of the current template.

This affects the IncludeNode, ExtendsNode, and InclusionNode.

--
Ticket URL: <https://code.djangoproject.com/ticket/24577>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Apr 3, 2015, 1:52:59 PM4/3/15
to django-...@googlegroups.com
#24577: Restrict extending and including to require templates from the same engine.
---------------------------------+------------------------------------

Reporter: prestontimmons | Owner: nobody
Type: Bug | Status: new
Component: Template system | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
---------------------------------+------------------------------------
Changes (by timgraham):

* needs_better_patch: => 0
* needs_docs: => 0
* needs_tests: => 0
* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/24577#comment:1>

Django

unread,
Jul 21, 2016, 12:09:45 PM7/21/16
to django-...@googlegroups.com
#24577: Restrict extending and including to require templates from the same engine.
---------------------------------+------------------------------------
Reporter: prestontimmons | Owner: sgzsh269
Type: Bug | Status: assigned

Component: Template system | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
---------------------------------+------------------------------------
Changes (by sgzsh269):

* owner: nobody => sgzsh269
* status: new => assigned


--
Ticket URL: <https://code.djangoproject.com/ticket/24577#comment:2>

Django

unread,
Jul 21, 2016, 12:11:08 PM7/21/16
to django-...@googlegroups.com
#24577: Restrict extending and including to require templates from the same engine.
---------------------------------+------------------------------------
Reporter: prestontimmons | Owner:

Type: Bug | Status: new
Component: Template system | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
---------------------------------+------------------------------------
Changes (by sgzsh269):

* owner: sgzsh269 =>
* status: assigned => new


--
Ticket URL: <https://code.djangoproject.com/ticket/24577#comment:3>

Django

unread,
Jan 17, 2017, 11:47:42 AM1/17/17
to django-...@googlegroups.com
#24577: Restrict extending and including to require templates from the same engine.
---------------------------------+------------------------------------
Reporter: Preston Timmons | Owner: nobody

Type: Bug | Status: new
Component: Template system | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
---------------------------------+------------------------------------
Changes (by Anton Samarchyan):

* cc: desecho@… (added)


Comment:

I can't reproduce this issue. Can you offer a sample project?

--
Ticket URL: <https://code.djangoproject.com/ticket/24577#comment:2>

Django

unread,
Feb 4, 2017, 10:58:34 AM2/4/17
to django-...@googlegroups.com
#24577: Restrict extending and including to require templates from the same engine.
---------------------------------+------------------------------------
Reporter: Preston Timmons | Owner: nobody

Type: Bug | Status: new
Component: Template system | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
---------------------------------+------------------------------------

Comment (by Tim Graham):

A start at solving this for `{% Include %}` is available as the second
commit of the [https://github.com/django/django/pull/7960 PR] for #27722.

--
Ticket URL: <https://code.djangoproject.com/ticket/24577#comment:3>

Django

unread,
Feb 10, 2017, 6:30:11 PM2/10/17
to django-...@googlegroups.com
#24577: Restrict extending and including to require templates from the same engine.
---------------------------------+------------------------------------
Reporter: Preston Timmons | Owner: nobody

Type: Bug | Status: new
Component: Template system | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
---------------------------------+------------------------------------
Changes (by Tim Graham):

* Attachment "24577.diff" added.

Reply all
Reply to author
Forward
0 new messages