[Django] #23258: Add note that Form.add_error is new in 1.7 in 'Form and field validation'

13 views
Skip to first unread message

Django

unread,
Aug 8, 2014, 4:53:48 AM8/8/14
to django-...@googlegroups.com
#23258: Add note that Form.add_error is new in 1.7 in 'Form and field validation'
-------------------------------+----------------------
Reporter: barklund | Owner: nobody
Type: Bug | Status: new
Component: Documentation | Version: 1.7-rc-2
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------+----------------------
It's a tiny documentation thing, but
[https://docs.djangoproject.com/en/1.7/ref/forms/validation/ the 'Form and
field validation' docs for Django 1.7] does not mention that
{{{Form.add_error}}} is a new method in Django 1.7.

--
Ticket URL: <https://code.djangoproject.com/ticket/23258>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Aug 8, 2014, 11:41:46 AM8/8/14
to django-...@googlegroups.com
#23258: Add note that Form.add_error is new in 1.7 in 'Form and field validation'
-------------------------------+--------------------------------------
Reporter: barklund | Owner: nobody
Type: Bug | Status: closed
Component: Documentation | Version: 1.7-rc-2
Severity: Normal | Resolution: worksforme
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 1
-------------------------------+--------------------------------------
Changes (by timgraham):

* status: new => closed
* needs_better_patch: => 0
* resolution: => worksforme
* needs_tests: => 0
* needs_docs: => 0


Comment:

If you click through to the
[https://docs.djangoproject.com/en/1.7/ref/forms/api/#django.forms.Form.add_error
Form.add_error()] reference, you'll see the note there. I don't think we
should add a note everywhere that the method appears.

--
Ticket URL: <https://code.djangoproject.com/ticket/23258#comment:1>

Django

unread,
Aug 8, 2014, 11:49:13 AM8/8/14
to django-...@googlegroups.com
#23258: Add note that Form.add_error is new in 1.7 in 'Form and field validation'
-------------------------------+--------------------------------------
Reporter: barklund | Owner: nobody
Type: Bug | Status: closed
Component: Documentation | Version: 1.7-rc-2
Severity: Normal | Resolution: worksforme
Keywords: | Triage Stage: Unreviewed

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 1
-------------------------------+--------------------------------------

Comment (by areski):

add_error has been added from this PR:
https://github.com/django/django/pull/1443

On the release notes there is a clear mention that add_error is added in
1.7: https://docs.djangoproject.com/en/dev/releases/1.7/#form-add-error

Here a PR in case we really want this, here a PR
https://github.com/django/django/pull/3036

--
Ticket URL: <https://code.djangoproject.com/ticket/23258#comment:2>

Reply all
Reply to author
Forward
0 new messages