[Django] #25116: Remove admindocs model-based bookmarklets
Django
--------------------------------------+--------------------------
Reporter: benspaulding | Owner: benspaulding
Type: Cleanup/optimization | Status: new
Component: contrib.admindocs | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Easy pickings: 1 | UI/UX: 0
--------------------------------------+--------------------------
The three admindocs bookmarklets that relate to models (show model type
and id, edit in admin in this window, and in new window) have not worked
since commit 64e11a6 (from ticket #13285) several years ago. There is not
a simple way to make these work again, unless we re-introduce something
like populate_xheaders, which is not reasonable. I think they should
simply be removed. (Feel free to reject this ticket if that opinion is not
shared.)
--
Ticket URL: <https://code.djangoproject.com/ticket/25116>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: benspaulding | Owner:
Type: | benspaulding
Cleanup/optimization | Status: new
Component: contrib.admindocs | Version: master
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by benspaulding):
* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0
Old description:
> The three admindocs bookmarklets that relate to models (show model type
> and id, edit in admin in this window, and in new window) have not worked
> since commit 64e11a6 (from ticket #13285) several years ago. There is not
> a simple way to make these work again, unless we re-introduce something
> like populate_xheaders, which is not reasonable. I think they should
> simply be removed. (Feel free to reject this ticket if that opinion is
> not shared.)
New description:
The three admindocs bookmarklets that relate to models (show model type
and id, edit in admin in this window, and in new window) have not worked
since commit 64e11a6 (from ticket #13285) several years ago. There is not
a simple way to make these work again, unless we re-introduce something
like populate_xheaders, which is not reasonable. I think they should
simply be removed. (Feel free to reject this ticket if that opinion is not
shared.)
This should make #8079 moot.
--
--
Ticket URL: <https://code.djangoproject.com/ticket/25116#comment:1>
Django
Reporter: benspaulding | Owner:
Type: | benspaulding
Component: contrib.admindocs | Version: master
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Description changed by benspaulding:
Old description:
> The three admindocs bookmarklets that relate to models (show model type
> and id, edit in admin in this window, and in new window) have not worked
> since commit 64e11a6 (from ticket #13285) several years ago. There is not
> a simple way to make these work again, unless we re-introduce something
> like populate_xheaders, which is not reasonable. I think they should
> simply be removed. (Feel free to reject this ticket if that opinion is
> not shared.)
>
> This should make #8079 moot.
New description:
The three admindocs bookmarklets that relate to models (show model type
and id, edit in admin in this window, and in new window) have not worked
since commit 64e11a6 (from ticket #13285) several years ago. There is not
a simple way to make these work again, unless we re-introduce something
like populate_xheaders, which is not reasonable. I think they should
simply be removed. (Feel free to reject this ticket if that opinion is not
shared.)
This should make #8079 moot.
Also, if #25115 lands first, we may also want to remove the logic in the
admindocs bookmarklet view that adds admin_url to the context.
--
--
Ticket URL: <https://code.djangoproject.com/ticket/25116#comment:2>
Django
Reporter: benspaulding | Owner:
Type: | benspaulding
Component: contrib.admindocs | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Changes (by aaugustin):
* stage: Unreviewed => Accepted
Comment:
Considering that it took three Django releases (1.6 to 1.8) for someone to
notice the problem, it's clear that this feature isn't used much if at all
and should be purged rather than fixed.
--
Ticket URL: <https://code.djangoproject.com/ticket/25116#comment:3>
Django
Reporter: benspaulding | Owner:
Type: | benspaulding
Component: contrib.admindocs | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Changes (by Tim Graham <timograham@…>):
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"83f63730306fa3cbdcbe7f0dcb36b0cdcfd1ec4a" 83f6373]:
{{{
#!CommitTicketReference repository=""
revision="83f63730306fa3cbdcbe7f0dcb36b0cdcfd1ec4a"
Fixed #25116 -- Removed long-broken admindocs bookmarklets
These were broken back in commit 64e11a6.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/25116#comment:4>