[Django] #31470: Overflow not respected when using `<pre>` tag in `<fieldset>` in the admin site.

14 views
Skip to first unread message

Django

unread,
Apr 15, 2020, 9:58:40 AM4/15/20
to django-...@googlegroups.com
#31470: Overflow not respected when using `<pre>` tag in `<fieldset>` in the admin
site.
-------------------------------------+-------------------------------------
Reporter: Nick Pope | Owner: Nick Pope
Type: | Status: assigned
Uncategorized |
Component: | Version: master
contrib.admin | Keywords: admin, fieldset,
Severity: Normal | pre, overflow
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 1 |
-------------------------------------+-------------------------------------
When using the `<pre>` tag to render a read-only block of code/markup with
syntax highlighting in a `<fieldset>`, overflow is not respected and the
`<pre>` forces the `<fieldset>` to be wider.

This can be resolved by setting `min-width: 0` on `fieldset` in CSS.

--
Ticket URL: <https://code.djangoproject.com/ticket/31470>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Apr 15, 2020, 9:59:19 AM4/15/20
to django-...@googlegroups.com
#31470: Overflow not respected when using `<pre>` tag in `<fieldset>` in the admin
site.
-------------------------------------+-------------------------------------
Reporter: Nick Pope | Owner: Nick Pope
Type: Uncategorized | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: admin, fieldset, | Triage Stage:
pre, overflow | Unreviewed
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Nick Pope):

* Attachment "without-fix.png" added.

Django

unread,
Apr 15, 2020, 9:59:27 AM4/15/20
to django-...@googlegroups.com
#31470: Overflow not respected when using `<pre>` tag in `<fieldset>` in the admin
site.
-------------------------------------+-------------------------------------
Reporter: Nick Pope | Owner: Nick Pope
Type: Uncategorized | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: admin, fieldset, | Triage Stage:
pre, overflow | Unreviewed
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Nick Pope):

* Attachment "with-fix.png" added.

Django

unread,
Apr 15, 2020, 10:03:31 AM4/15/20
to django-...@googlegroups.com
#31470: Overflow not respected when using `<pre>` tag in `<fieldset>` in the admin
site.
-------------------------------------+-------------------------------------
Reporter: Nick Pope | Owner: Nick Pope
Type: Uncategorized | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: admin, fieldset, | Triage Stage:
pre, overflow | Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Nick Pope):

* has_patch: 0 => 1


Comment:

[https://github.com/django/django/pull/12725 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/31470#comment:1>

Django

unread,
Apr 16, 2020, 12:55:02 AM4/16/20
to django-...@googlegroups.com
#31470: Overflow not respected when using `<pre>` tag in `<fieldset>` in the admin
site.
-------------------------------------+-------------------------------------
Reporter: Nick Pope | Owner: Nick Pope
Type: | Status: assigned
Cleanup/optimization |

Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: admin, fieldset, | Triage Stage: Accepted
pre, overflow |
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by felixxm):

* type: Uncategorized => Cleanup/optimization
* stage: Unreviewed => Accepted


Comment:

Thanks, I reproduced this issue.

--
Ticket URL: <https://code.djangoproject.com/ticket/31470#comment:2>

Django

unread,
Apr 16, 2020, 2:15:42 AM4/16/20
to django-...@googlegroups.com
#31470: Overflow not respected when using `<pre>` tag in `<fieldset>` in the admin
site.
-------------------------------------+-------------------------------------
Reporter: Nick Pope | Owner: Nick Pope
Type: | Status: assigned
Cleanup/optimization |
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: admin, fieldset, | Triage Stage: Ready for
pre, overflow | checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by felixxm):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/31470#comment:3>

Django

unread,
Apr 16, 2020, 4:48:04 AM4/16/20
to django-...@googlegroups.com
#31470: Overflow not respected when using `<pre>` tag in `<fieldset>` in the admin
site.
-------------------------------------+-------------------------------------
Reporter: Nick Pope | Owner: Nick Pope
Type: | Status: closed

Cleanup/optimization |
Component: contrib.admin | Version: master
Severity: Normal | Resolution: fixed

Keywords: admin, fieldset, | Triage Stage: Ready for
pre, overflow | checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson <carlton@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"daabb102c059119504dc6c78a2e2dc62c9d572b8" daabb102]:
{{{
#!CommitTicketReference repository=""
revision="daabb102c059119504dc6c78a2e2dc62c9d572b8"
Fixed #31470 -- Fixed fieldset admin CSS to prevent overflowing <pre>
elements.

Co-Authored-By: Mariusz Felisiak <felisiak...@gmail.com>
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/31470#comment:4>

Reply all
Reply to author
Forward
0 new messages