Re: [Django] #35791: Icon buttons must be at least 24x24 pixels

Django

unread,

Oct 30, 2024, 11:54:52 PM10/30/24

to django-...@googlegroups.com

#35791: Icon buttons must be at least 24x24 pixels
-------------------------------------+-------------------------------------
Reporter: Eva Nanyonga | Owner: Eva
Type: | Nanyonga
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: Accessibility, WCAG | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Comment (by Alexander Lazarević):

Eva, have you planned to continue working on it?
--
Ticket URL: <https://code.djangoproject.com/ticket/35791#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,

Nov 1, 2024, 8:42:52 AM11/1/24

to django-...@googlegroups.com

#35791: Icon buttons must be at least 24x24 pixels
-------------------------------------+-------------------------------------
Reporter: Eva Nanyonga | Owner: Eva
Type: | Nanyonga
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: Accessibility, WCAG | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Alexander Lazarević):

* cc: Alexander Lazarević (added)

--
Ticket URL: <https://code.djangoproject.com/ticket/35791#comment:6>

Django

unread,

Nov 1, 2024, 9:11:52 PM11/1/24

to django-...@googlegroups.com

#35791: Icon buttons must be at least 24x24 pixels
-------------------------------------+-------------------------------------
Reporter: Eva Nanyonga | Owner: Eva
Type: | Nanyonga
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:

Keywords: Accessibility, | Triage Stage: Accepted
WCAG,Djangonauts |

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Alexander Lazarević):

* cc: Alexander Lazarević (removed)
* keywords: Accessibility, WCAG => Accessibility, WCAG,Djangonauts

--
Ticket URL: <https://code.djangoproject.com/ticket/35791#comment:7>

Django

unread,

Nov 5, 2024, 5:15:24 AM11/5/24

to django-...@googlegroups.com

#35791: Icon buttons must be at least 24x24 pixels
-------------------------------------+-------------------------------------

Reporter: Eva Nanyonga | Owner: Mariusz
Type: | Felisiak

Changes (by Mariusz Felisiak):

* owner: Eva Nanyonga => Mariusz Felisiak

--
Ticket URL: <https://code.djangoproject.com/ticket/35791#comment:8>

Django

unread,

Nov 5, 2024, 11:45:51 AM11/5/24

to django-...@googlegroups.com

#35791: Icon buttons must be at least 24x24 pixels
-------------------------------------+-------------------------------------
Reporter: Eva Nanyonga | Owner:

Type: | tainarapalmeira

Changes (by tainarapalmeira):

* owner: Mariusz Felisiak => tainarapalmeira

--
Ticket URL: <https://code.djangoproject.com/ticket/35791#comment:9>

Django

unread,

Nov 13, 2024, 8:10:23 AM11/13/24

to django-...@googlegroups.com

#35791: Icon buttons must be at least 24x24 pixels
-------------------------------------+-------------------------------------

Reporter: Eva Nanyonga | Owner: rohan
Type: | yadav

Changes (by rohan yadav):

* owner: tainarapalmeira => rohan yadav

Comment:

I have submitted the PR .. can anybody review that please
--
Ticket URL: <https://code.djangoproject.com/ticket/35791#comment:10>

Django

unread,

Nov 13, 2024, 11:17:27 AM11/13/24

to django-...@googlegroups.com

#35791: Icon buttons must be at least 24x24 pixels
-------------------------------------+-------------------------------------
Reporter: Eva Nanyonga | Owner:

Type: | tainarapalmeira

Changes (by Sarah Boyce):

* owner: rohan yadav => tainarapalmeira

Comment:

Hi Rohan, this was assigned to tainarapalmeira recently (note that I
understand Mariusz had reserved this for her).
You should ask folks if they are still working on it before taking over a
ticket if they have been active recently (recently means within the past
couple of months).

Also, please make sure you review comments from previous pull requests and
address them, you have not addressed this comment:
https://github.com/django/django/pull/18624#issuecomment-2380660463

Tainara if you're working on this, please feel free to raise a PR 👍
--
Ticket URL: <https://code.djangoproject.com/ticket/35791#comment:11>

Django

unread,

Nov 13, 2024, 11:33:17 AM11/13/24

to django-...@googlegroups.com

#35791: Icon buttons must be at least 24x24 pixels
-------------------------------------+-------------------------------------
Reporter: Eva Nanyonga | Owner:
Type: | tainarapalmeira
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: Accessibility, | Triage Stage: Accepted
WCAG,Djangonauts |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by rohan yadav):

Hi Sarah,
sorry i didn't know much about ownership of the ticket , as i am new to
the community .
If Tainara isn't looking on the issue , I would love to do it . For the
next PR, I will make sure reviewing any comments.
Thanks
--
Ticket URL: <https://code.djangoproject.com/ticket/35791#comment:12>

Django

unread,

Nov 14, 2024, 5:01:45 AM11/14/24

to django-...@googlegroups.com

#35791: Icon buttons must be at least 24x24 pixels
-------------------------------------+-------------------------------------
Reporter: Eva Nanyonga | Owner:
Type: | tainarapalmeira
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: Accessibility, | Triage Stage: Accepted
WCAG,Djangonauts |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak):

* cc: Mariusz Felisiak (added)

--
Ticket URL: <https://code.djangoproject.com/ticket/35791#comment:13>

Django

unread,

Nov 16, 2024, 6:06:01 AM11/16/24

to django-...@googlegroups.com

#35791: Icon buttons must be at least 24x24 pixels
-------------------------------------+-------------------------------------
Reporter: Eva Nanyonga | Owner:
Type: | tainarapalmeira
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: Accessibility, | Triage Stage: Accepted
WCAG,Djangonauts |
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by tainarapalmeira):

* needs_better_patch: 1 => 0

Comment:

Hi there,

I've submitted a new patch for this ticket, and you can find it at the
following link: https://github.com/django/django/pull/18816.
--
Ticket URL: <https://code.djangoproject.com/ticket/35791#comment:14>

Django

unread,

Nov 28, 2024, 9:27:15 AM11/28/24

to django-...@googlegroups.com

#35791: Icon buttons must be at least 24x24 pixels
-------------------------------------+-------------------------------------
Reporter: Eva Nanyonga | Owner:
Type: | tainarapalmeira
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:

Keywords: Accessibility, | Triage Stage: Ready for
WCAG,Djangonauts | checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Sarah Boyce):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/35791#comment:15>

Django

unread,

Nov 29, 2024, 2:31:16 AM11/29/24

to django-...@googlegroups.com

#35791: Icon buttons must be at least 24x24 pixels
-------------------------------------+-------------------------------------
Reporter: Eva Nanyonga | Owner:
Type: | tainarapalmeira

Cleanup/optimization | Status: closed
Component: contrib.admin | Version: dev
Severity: Normal | Resolution: fixed

Keywords: Accessibility, | Triage Stage: Ready for
WCAG,Djangonauts | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Sarah Boyce <42296566+sarahboyce@…>):

* resolution: => fixed
* status: assigned => closed

Comment:

In [changeset:"86661f2449fb0903f72b3522c68e146934013377" 86661f2]:
{{{#!CommitTicketReference repository=""
revision="86661f2449fb0903f72b3522c68e146934013377"
Fixed #35791 -- Updated icon button dimensions to 24x24 pixels.

This is to meet the WCAG 2.5.8 minimum size requirement.

Co-authored-by: Eva Nanyonga <eve...@gmail.com>
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35791#comment:16>
Django <https://code.djangoproject.com/>
The web framework for perfectionists with deadlines.

Django

unread,

Sep 4, 2025, 12:36:14 PM (3 days ago) Sep 4

to django-...@googlegroups.com

#35791: Icon buttons must be at least 24x24 pixels
-------------------------------------+-------------------------------------
Reporter: Eva Nanyonga | Owner:
Type: | tainarapalmeira
Cleanup/optimization | Status: closed
Component: contrib.admin | Version: dev
Severity: Normal | Resolution: fixed
Keywords: Accessibility, | Triage Stage: Ready for
WCAG,Djangonauts | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by nessita <124304+nessita@…>):

In [changeset:"c595af65457e44221aa56cab25e1b5766d802b8f" c595af6]:
{{{#!CommitTicketReference repository=""
revision="c595af65457e44221aa56cab25e1b5766d802b8f"
Fixed #36578, Refs #35791 -- Ensured inline delete icon scales and stays
centered in the admin.

Regression in 87ab54b488cb58d810939112f208bb37068710e0. Refs #35829.

Thank you Natalia Bidart for the review.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35791#comment:17>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Reply all

Reply to author

Forward